Breaking: Rename stripBOM option to removeBOM

gulpjs · Nov 30, 2017 · bfb56cd · bfb56cd
1 parent d5014e4
commit bfb56cd
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 6 deletions.
diff --git a/lib/src/options.js b/lib/src/options.js
@@ -12,7 +12,7 @@ var config = {
   since: {
     type: 'date',
   },
-  stripBOM: {
+  removeBOM: {
     type: 'boolean',
     default: true,
   },

diff --git a/lib/src/read-contents/read-buffer.js b/lib/src/read-contents/read-buffer.js
@@ -11,8 +11,8 @@ function bufferFile(file, optResolver, onRead) {
       return onRead(readErr);
     }
 
-    var stripBOM = optResolver.resolve('stripBOM', file);
-    if (stripBOM) {
+    var removeBOM = optResolver.resolve('removeBOM', file);
+    if (removeBOM) {
       file.contents = removeBomBuffer(data);
     } else {
       file.contents = data;

diff --git a/lib/src/read-contents/read-stream.js b/lib/src/read-contents/read-stream.js
@@ -13,12 +13,12 @@ function streamFile(file, optResolver, onRead) {
 
   var filePath = file.path;
 
-  var stripBOM = optResolver.resolve('stripBOM', file);
+  var removeBOM = optResolver.resolve('removeBOM', file);
 
   file.contents = new lazystream.Readable(function() {
     var contents = fs.createReadStream(filePath);
 
-    if (stripBOM) {
+    if (removeBOM) {
       return contents.pipe(removeBomStream());
     }
 

diff --git a/test/src.js b/test/src.js
@@ -152,7 +152,7 @@ describe('.src()', function() {
     }
 
     pipe([
-      vfs.src(bomInputPath, { stripBOM: false }),
+      vfs.src(bomInputPath, { removeBOM: false }),
       concat(assert),
     ], done);
   });