-
-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vfs.dest(outfolder, { base.. }) ignores outfolder? #141
Comments
can you supply an example of what you are talking about and what your suggestion is? |
Well, the example is:
Here Actually, I'm a little bit confused about the use case of it. If one wants to use a function to calculate a folder, can use:
|
I think the |
@phated I think the fix here is to make the base option work correctly not to remove it. Also open to removing it though if it isn't providing any value |
@contra what is the correct way it should operate if you are using a function for dest? |
@iliakan @contra do you think the correct behavior is: vfs.dest('./test', {
base: '/my/base'
});
// Writes files at /my/base/test
vfs.dest('/my/path', {
base: '/other/base'
});
// Writes files at /my/path This would essentially resolve the dest path from the base path which allows handling of relative paths correctly. Thoughts? |
Maybe this should just be |
@phated should this change break tests? I've developed a test branch with what you commented on above, is this what you were thinking? |
@tmcgee123 I don't think my last comment was correct. I'm not sure what the "correct" behavior would be. Any thoughts? @contra @iliakan |
Thinking through this some more with @stevelacy, the only example I can come up with where the // src = './client/**/*.sass'
vfs.dest('./dest/styles/');
// => /home/user/project/dest/styles/sass/file.sass
// => /home/user/project/dest/styles/sass/partials/other-file.sass
// src = './client/**/*.css'
vfs.dest('./dest/styles/', {
base: './sass'
});
// => /home/user/project/dest/styles/file.css
// => /home/user/project/dest/styles/partials/other-file.css However, it seems that this can be solved by using the |
When
dest
has abase
option, it ignoresoutfolder
, right?Looks like that from the code.
If yes, then maybe let people specify empty
outfolder
?The text was updated successfully, but these errors were encountered: