Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review default for useJunctions option #247

Closed
phated opened this issue Jun 23, 2017 · 0 comments
Closed

Review default for useJunctions option #247

phated opened this issue Jun 23, 2017 · 0 comments
Labels
bug

Comments

@phated
Copy link
Member

phated commented Jun 23, 2017

As per @erikkemperman's comment in #246, we likely don't want to use file.isDirectory() inside the defaulter method.
@phated phated added the bug label Jun 23, 2017
@phated phated closed this as completed in 82de270 Jun 26, 2017
phated added a commit that referenced this issue Nov 27, 2017
@phated
Fix: Avoid file.isDirectory in useJunctions default (fixes #247) (#…
93cea43 
…252)
phated added a commit that referenced this issue Nov 27, 2017
@phated
Fix: Avoid file.isDirectory in useJunctions default (fixes #247) (#…
676f745 
…252)
phated added a commit that referenced this issue Nov 27, 2017
@phated
Fix: Avoid file.isDirectory in useJunctions default (fixes #247) (#…
62893f0 
…252)
phated added a commit that referenced this issue Nov 27, 2017
@phated
Fix: Avoid file.isDirectory in useJunctions default (fixes #247) (#…
e1c2133 
…252)
phated added a commit that referenced this issue Nov 27, 2017
@phated
Fix: Avoid file.isDirectory in useJunctions default (fixes #247) (#…
0fe2014 
…252)
phated added a commit that referenced this issue Nov 27, 2017
@phated
Fix: Avoid file.isDirectory in useJunctions default (fixes #247) (#…
d0d54c7 
…252)
phated added a commit that referenced this issue Nov 27, 2017
@phated
Fix: Avoid file.isDirectory in useJunctions default (fixes #247) (#…
c5a3433 
…252)
phated added a commit that referenced this issue Nov 28, 2017
@phated
Fix: Avoid file.isDirectory in useJunctions default (fixes #247) (#…
2641e3e 
…252)
phated added a commit that referenced this issue Nov 28, 2017
@phated
Fix: Avoid file.isDirectory in useJunctions default (fixes #247) (#…
5c8f0a2 
…252)
phated added a commit that referenced this issue Nov 28, 2017
@phated
Fix: Avoid file.isDirectory in useJunctions default (fixes #247) (#…
ac962a7 
…252)
phated added a commit that referenced this issue Nov 28, 2017
@phated
Fix: Avoid file.isDirectory in useJunctions default (fixes #247) (#…
30cd614 
…252)
phated added a commit that referenced this issue Nov 28, 2017
@phated
Fix: Avoid file.isDirectory in useJunctions default (fixes #247) (#…
8fc4b3f 
…252)
phated added a commit that referenced this issue Nov 28, 2017
@phated
Fix: Avoid file.isDirectory in useJunctions default (fixes #247) (#…
2ad80b1 
…252)
phated added a commit that referenced this issue Nov 28, 2017
@phated
Fix: Avoid file.isDirectory in useJunctions default (fixes #247) (#…
85799a1 
…252)
phated added a commit that referenced this issue Nov 28, 2017
@phated
Fix: Avoid file.isDirectory in useJunctions default (fixes #247) (#…
1df9625 
…252)
phated added a commit that referenced this issue Nov 28, 2017
@phated
Fix: Avoid file.isDirectory in useJunctions default (fixes #247) (#…
b1da35e 
…252)
phated added a commit that referenced this issue Nov 28, 2017
@phated
Fix: Avoid file.isDirectory in useJunctions default (fixes #247) (#…
a557e47 
…252)
phated added a commit that referenced this issue Nov 28, 2017
@phated
Fix: Avoid file.isDirectory in useJunctions default (fixes #247) (#…
5dc1f73 
…252)
phated added a commit that referenced this issue Nov 28, 2017
@phated
Fix: Avoid file.isDirectory in useJunctions default (fixes #247) (#…
edefe42 
…252)
phated added a commit that referenced this issue Nov 28, 2017
@phated
Fix: Avoid file.isDirectory in useJunctions default (fixes #247) (#…
e1376b8 
…252)
phated added a commit that referenced this issue Nov 28, 2017
@phated
Fix: Avoid file.isDirectory in useJunctions default (fixes #247) (#…
9d7e59b 
…252)
phated added a commit that referenced this issue Nov 28, 2017
@phated
Fix: Avoid file.isDirectory in useJunctions default (fixes #247) (#…
9be4bec 
…252)
phated added a commit that referenced this issue Nov 28, 2017
@phated
Fix: Avoid file.isDirectory in useJunctions default (fixes #247) (#…
77e0fcf 
…252)
phated added a commit that referenced this issue Nov 28, 2017
@phated
Fix: Avoid file.isDirectory in useJunctions default (fixes #247) (#…
daf337f 
…252)
phated added a commit that referenced this issue Nov 28, 2017
@phated
Fix: Avoid file.isDirectory in useJunctions default (fixes #247) (#…
1a6243e 
…252)
phated added a commit that referenced this issue Nov 28, 2017
@phated
Fix: Avoid file.isDirectory in useJunctions default (fixes #247) (#…
1170180 
…252)
phated added a commit that referenced this issue Nov 30, 2017
@phated
Fix: Avoid file.isDirectory in useJunctions default (fixes #247) (#…
e32721c 
…252)
phated added a commit that referenced this issue Nov 30, 2017
@phated
Fix: Avoid file.isDirectory in useJunctions default (fixes #247) (#…
3e1dfb2 
…252)
phated added a commit that referenced this issue Nov 30, 2017
@phated
Fix: Avoid file.isDirectory in useJunctions default (fixes #247) (#…
7045cf2 
…252)
phated added a commit that referenced this issue Nov 30, 2017
@phated
Fix: Avoid file.isDirectory in useJunctions default (fixes #247) (#…
8c03f5a 
…252)
phated added a commit that referenced this issue Nov 30, 2017
@phated
Fix: Avoid file.isDirectory in useJunctions default (fixes #247) (#…
a741486 
…252)
phated added a commit that referenced this issue Dec 5, 2017
@phated
Fix: Avoid file.isDirectory in useJunctions default (fixes #247) (#…
6b2567b 
…252)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@phated