Rebase review!!!

[phated]

@stevelacy @contra @erikkemperman @terinjokes

I've just finished the 3.0 rebase at https://github.com/gulpjs/vinyl-fs/commits/rebase-3.0 - please please please do a thorough review of said rebase. Once I get some sign-offs, I'll re-tag all the releases, publish all the changelogs, force push to master and release 3.0

[terinjokes]

Hey @phated!

I can take a look. Do you have recommendations for things I should be keeping my eyes peeled for?

[phated]

• Make sure I didn't hijack any commits from people (when I split commits apart, etc)
• Verify the messages make sense
• Check my conventional changelog prefixes
• other stuff?

[erikkemperman]

@phated Final push, excellent! The commit messages look fine, and I quickly diffed against master to find all is the same, as expected (well, except for version in package.json.)

LGTM!

[stephenlacy]

I found three commits that seem to have author issues, especially since there were prior and later commits with their correct authorship.
1f085e0
c196935
bcfd342

[erikkemperman]

@stevelacy Just a guess, but I think those might be GH accounts that no longer exist?

[stephenlacy]

They would be linked to the @ghost account if there were deleted.

It seems that some of the contributors do not have their correct email linked to github:
https://github.com/oconnore/vinyl-fs/commits/master
https://github.com/vineethawal/vinyl-fs

[phated]

I'm not going to fix random contributor's emails that they deleted in their GitHub settings.

[stephenlacy]

No worries, everything else looks good

[phated]

Alright all. I'm shipping this today.

[phated]

Whoops, rolling that back. There's some skipped tests that I needed to make work and those were breaking.

[phated]

Published!

[erikkemperman]

@phated
Congrats on the 3.0.0 release, and thanks for persevering!

Quick question, what's your idea about the "closed by rebase" PRs? I could try updating some (I'd especially hate to see the encoding effort buried) but then again if you prefer to forget about them for awhile that's cool too.

[erikkemperman]

@phated Nevermind, just saw #257 (comment)

[phated]

@erikkemperman yeah, sorry about that. I realized too late that I should change the base branch for the open PRs ☹️

[erikkemperman]

No worries, had to resolve a bunch of conflicts either way :-)