Update: Support encoding option
#257
Conversation
Fix mode comparison
this relies on the recent breaking changes to glob-watcher being published to npm as 2.0
switch to glob-watcher 2.0
It has been shown in gulpjs#62 this bit can be platform specific and is unreliable, testing fs.chmod is not called will be enough.
Remove realMode equality test on special bit test
export `filterSince` to `vinyl-filter-since`
specifying the type and URL is deprecated: https://docs.npmjs.com/files/package.json#license http://npm1k.org/
update license attribute
Update vinyl to 0.5.x
using is-valid-glob module to handle nested arrays properly
Fix default option in README
Because the stream returned from `dest` is also readable, it is kinda link a `src` to the next `dest` so the `base` should be configurable just like `src`.
Improvements
|
@phated Yeah, it shouldn't be a breaking change. But on the other hand, if it's ready and stable why not include it -- the already big changelog wouldn't get that much bigger with this in, it seems to me. I appreciate and agree it should not block anything, but maybe let's see where this PR is at when you feel 3.0 is otherwise mature? |
|
@erikkemperman Sorry if I was unclear. My statements were more about me not wanting to put time into my ideas until we wrap up the absolute blockers for 3.0 (symlinks, mainly). If something comes to me randomly, I'll definitely work on this and if it lands before 3, that will be fine. |
|
@phated All righty. By the way, I've been looking at the symlink (well, junction) stuff again but am now slightly doubtful we can safely re-use stats in |
|
Sounds good! |
erikkemperman
force-pushed
the
encoding
branch
from
fa2be6c to
0249aaa
Compare
|
@phated Rebased this for good measure. I would love to see something like this in 3.0, but you mentioned you had ideas for improvement and I'd totally understand if you prefer to keep this on the shelf for the time being. |
erikkemperman
force-pushed
the
encoding
branch
from
0249aaa to
f6b1555
Compare
|
While I think this is beneficial for the API, I want to spend my time focused on the large changeset we currently have and ensure that it works for everyone. We don't have nearly enough eyes on the 3.0 changes. |
|
This was closed due to me rebasing master. Please resubmit it to the updated codebase. |
|
Done, #287 |
Waiting for a bit of inspiration for the symlink/junction thing, I figured I might take a stab at #23.
It is a kind of "shallow" way to deal with encodings, limited to the filesystem terminals
srcanddest-- internally all buffers and streams are (still) UTF-8.This has the advantage of (probably) not breaking any plugins, but incurs some needless (and in some scenarios perhaps even lossy) conversion when both source and destination files are in the same non-UTF8 encoding.