Bump deps #278
Merged
Bump deps #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phated
reviewed
Sep 25, 2017
lib/file-operations.js
Outdated
| @@ -73,12 +73,12 @@ function getModeDiff(fsMode, vinylMode) { | |||
|
|
|||
| function getTimesDiff(fsStat, vinylStat) { | |||
|
|
|||
| var mtime = date(vinylStat.mtime); | |||
| var mtime = date(vinylStat.mtime) || null; | |||
There was a problem hiding this comment.
Because value-or-function now returns undefined for invalid input, and the expression below this line is expecting null: Oddly +null yields 0, whereas +undefined yields NaN, for some reason.
There was a problem hiding this comment.
Maybe we should make them 0 then?
There was a problem hiding this comment.
Yeah, that would work. But now that I look at this again, the expressions with + seem slightly wrong here. Aren't we discounting 0 as a valid date (namely 1970-01-01 00:00:00)? Unlikely to ever come up, I guess, but still.
Anyway, I've amended to 0 for now.
|
Thanks @erikkemperman 😺 |
phated
pushed a commit
that referenced
this pull request
Nov 27, 2017
phated
pushed a commit
that referenced
this pull request
Nov 27, 2017
phated
pushed a commit
that referenced
this pull request
Nov 27, 2017
phated
pushed a commit
that referenced
this pull request
Nov 27, 2017
phated
pushed a commit
that referenced
this pull request
Nov 27, 2017
phated
pushed a commit
that referenced
this pull request
Nov 27, 2017
phated
pushed a commit
that referenced
this pull request
Nov 27, 2017
phated
pushed a commit
that referenced
this pull request
Nov 28, 2017
phated
pushed a commit
that referenced
this pull request
Nov 28, 2017
phated
pushed a commit
that referenced
this pull request
Nov 28, 2017
phated
pushed a commit
that referenced
this pull request
Nov 28, 2017
phated
pushed a commit
that referenced
this pull request
Nov 28, 2017
phated
pushed a commit
that referenced
this pull request
Nov 28, 2017
phated
pushed a commit
that referenced
this pull request
Nov 28, 2017
phated
pushed a commit
that referenced
this pull request
Nov 28, 2017
phated
pushed a commit
that referenced
this pull request
Nov 28, 2017
phated
pushed a commit
that referenced
this pull request
Nov 28, 2017
phated
pushed a commit
that referenced
this pull request
Nov 28, 2017
phated
pushed a commit
that referenced
this pull request
Nov 28, 2017
phated
pushed a commit
that referenced
this pull request
Nov 28, 2017
phated
pushed a commit
that referenced
this pull request
Nov 28, 2017
phated
pushed a commit
that referenced
this pull request
Nov 28, 2017
phated
pushed a commit
that referenced
this pull request
Nov 28, 2017
phated
pushed a commit
that referenced
this pull request
Nov 28, 2017
phated
pushed a commit
that referenced
this pull request
Nov 28, 2017
phated
pushed a commit
that referenced
this pull request
Nov 28, 2017
phated
pushed a commit
that referenced
this pull request
Nov 30, 2017
phated
pushed a commit
that referenced
this pull request
Nov 30, 2017
phated
pushed a commit
that referenced
this pull request
Nov 30, 2017
phated
pushed a commit
that referenced
this pull request
Nov 30, 2017
phated
pushed a commit
that referenced
this pull request
Nov 30, 2017
phated
pushed a commit
that referenced
this pull request
Dec 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@phated Sorry if this redundant, I know you were also visiting deps. Still, the value-or-function upgrade turned out to be slightly quirky so wanted to submit this just in case.