Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to glob-watcher 2.0 #64

Merged
merged 1 commit into from
Mar 22, 2015
Merged

switch to glob-watcher 2.0 #64

merged 1 commit into from
Mar 22, 2015

Conversation

phated
Copy link
Member

@phated phated commented Mar 22, 2015

this relies on the recent breaking changes to glob-watcher being published to npm as 2.0

@contra this will cause vinyl-fs to require a 2.0 bump also.

this relies on the recent breaking changes to glob-watcher being published to npm as 2.0
yocontra pushed a commit that referenced this pull request Mar 22, 2015
switch to glob-watcher 2.0
@yocontra yocontra merged commit 7939952 into gulpjs:master Mar 22, 2015
@yocontra
Copy link
Member

Will bump vinyl-fs to 2 after I finish some other fixes

@phated
Copy link
Member Author

phated commented Mar 22, 2015

Sounds good to me 🎂

@timelf123
Copy link

I just had an issue where vinyl-fs' version of gaze@0.5.x doesn't pay attention to maxListeners: 0. It should set them to infinite but currently ignores the option (but fixed on 0.6.x and higher). I am passing in maxListeners as a workaround:

gulp.watch(files, { maxListeners: 999 }, ['taskName'])

@yocontra
Copy link
Member

@timelf123 You should open an issue on gaze and ask them to push a fix to the 0.5 branch as a patch release then.

@timelf123
Copy link

Done: shama/gaze#193

@timelf123
Copy link

Is it possible to bump the version of gaze required since the issue has been fixed on 0.6? Seems silly to backport a fix when the next minor version took care of it

@yocontra
Copy link
Member

@timelf123 the 0.6 branch is full of bugs and doesn't work, this is all over the gaze project and the gulp project - 0.6 is broken, nobody can use it. It may have fixed some bugs but it introduced more issues than it solved. It won't even install on most platforms.

@timelf123
Copy link

My mistake, I didn't even test :P Just read that that specific bug was fixed. Thanks for clarifying

phated pushed a commit that referenced this pull request Dec 5, 2017
switch to glob-watcher 2.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants