onWritten is not defined

[jonschlinkert]

https://github.com/gulpjs/vinyl-fs/blob/master/lib/symlink/link-file.js#L30

[phated]

ping @erikkemperman - I'm not sure which callback it's supposed to call there. I believe this was pulled from another chunk of code by erik

[phated]

Looks like it should just be callback and was pulled from https://github.com/gulpjs/vinyl-fs/blob/master/lib/dest/write-contents/write-symbolic-link.js#L28-L31

[jonschlinkert]

fwiw it didn't cause me any problems, I didn't have time to write more earlier. I just noticed it in the code and wanted to let you know.

As much as we all like to act like code snobs about stuff like this, it happens to everyone. Linters are still run by humans lol.

[phated]

No worries. Our linting setup needs a lot of work.

[erikkemperman]

#299

Indeed, this looks like a sloppy/paste from dest to symlink on my part. Apologies, I do usually try to take note of lint output!

Also, this path is apparently not covered by the tests -- or we would have caught this obviously -- but I didn't have time to remedy that just now. For what it's worth, we get here only on Windows, when creating a symlink to a target which exists but can't be statted (as in permissions, I guess).

[erikkemperman]

PS thanks @jonschlinkert for reporting this -- much better to address this before it actually burns anyone.