#129 - Update documentation to more clearly explain what happens for default base option values. #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s for default base option values.
| - Default is where the glob begins if any. | ||
| - Default is `process.cwd()` if there is no glob. | ||
| - Default is where the glob begins, if any. For example, `path/to/**/*.js` would resolve to `path/to`. | ||
| - If there is no glob (i.e. a file path with no pattern), then the dirname of the path is used. For example, `path/to/some/file.js` would resolve to `path/to/some`. |
There was a problem hiding this comment.
This is sort of an implementation detail in that glob2base is used (and that glob-parent may be used in the future), however this hopefully better describes what happens even if it doesn't describe exactly what glob2base is doing internally.
|
Thanks! |
phated
added a commit
that referenced
this pull request
Dec 16, 2015
#129 - Update documentation to more clearly explain what happens for default base option values.
phated
added a commit
that referenced
this pull request
Dec 5, 2017
#129 - Update documentation to more clearly explain what happens for default base option values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After discussing it with @phated in #129, it seems to me that the previous description of the default
basevalue is incorrect in the docs. I was originally unsure where the source of truth was (docs or code) but it seems that the code is correct.