Allow specify dest sourcemaps option as string #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -226,7 +224,7 @@ vfs.dest('./', { | |||
| }); | |||
| ``` | |||
|
|
|||
| Type: `Boolean` or `Object` | |||
| Type: `Boolean`, `String` or `Object` | |||
There was a problem hiding this comment.
Needs more docs on what each type does
|
@contra Done. |
| @@ -199,7 +199,8 @@ Default: `true` (always overwrite existing files) | |||
|
|
|||
| ##### `options.sourcemaps` | |||
|
|
|||
| Enables sourcemap support on files passed through the stream. Will write inline soucemaps if specified as `true`. Uses [gulp-sourcemaps] under the hood. | |||
| Enables sourcemap support on files passed through the stream. Will write inline soucemaps if specified as `true`. | |||
| Will write sourcemaps file in relative to destination folder if specified as `string`. Uses [gulp-sourcemaps] under the hood. | |||
There was a problem hiding this comment.
I think it would be clearer to say "Specifying a string is shorthand for the path option"
|
Fixed. |
yocontra
pushed a commit
that referenced
this pull request
Feb 28, 2016
Allow specify dest sourcemaps option as string
|
@contra Will you publish patch release? |
|
This requires a minor release |
|
@phated Oh, sure. |
|
I tagged this. Will publish sometime after the CI tests run |
|
But tests are already passed in CI. |
|
Published as 2.4.0 |
|
Nice. Thanks. |
phated
pushed a commit
that referenced
this pull request
Dec 5, 2017
Allow specify dest sourcemaps option as string
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this will be much prettier and consistently.