-
-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: Switch stream implementation to streamx #333
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating this. I've made some comments, but they are mostly for me to remember what needs to be done to finish up this PR
1872d25
to
b88a77e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests should be green now and I'm happy enough with the diff. Thanks for getting this started @coreyfarrell and thanks for updating @sttk 🎉 This truly was a team effort.
This PR inherits #322 and updates this repository more for the following points:
Upgrades dependencies and drops node <10.13 support
rimraf
's version is 3, not latest, because the latest version 4 supports only node>=14.eslint
,expect
, andmocha
upgrades to the last versions which supports node v10.Drops
through2
and makes use ofstreamx
Drops
mississippi
andreadable-stream
Drops
remove-bom-buffer
, butis-utf8
is used.Skips 2 test cases about directory symlink on Node.js v10 and Windows
Because
EPERM
error occurs only on this environment.In addition, I tryed to drop
pumpify
by usingstreamx
, etc. in.dest()
and.symlink()
but cloudn't do them.NOTE: This package depends on
glob-stream
which will be bumped up.