Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Switch stream implementation to streamx #333

Merged
merged 61 commits into from
Jun 11, 2023

Conversation

sttk
Copy link
Contributor

@sttk sttk commented Mar 19, 2023

This PR inherits #322 and updates this repository more for the following points:

  1. Upgrades dependencies and drops node <10.13 support

    • rimraf's version is 3, not latest, because the latest version 4 supports only node>=14.
    • eslint, expect, and mocha upgrades to the last versions which supports node v10.
    • Other dependencies upgrades latest versions.
  2. Drops through2 and makes use of streamx

  3. Drops mississippi and readable-stream

  4. Drops remove-bom-buffer, but is-utf8 is used.

  5. Skips 2 test cases about directory symlink on Node.js v10 and Windows

    Because EPERM error occurs only on this environment.

In addition, I tryed to drop pumpify by using streamx, etc. in .dest() and .symlink() but cloudn't do them.

NOTE: This package depends on glob-stream which will be bumped up.

@sttk sttk requested a review from phated March 19, 2023 10:36
Copy link
Member

@phated phated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating this. I've made some comments, but they are mostly for me to remember what needs to be done to finish up this PR

LICENSE Outdated Show resolved Hide resolved
lib/codecs.js Outdated Show resolved Hide resolved
lib/src/index.js Show resolved Hide resolved
lib/src/read-contents/read-buffer.js Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
test/codecs.js Outdated Show resolved Hide resolved
test/src-symlinks.js Outdated Show resolved Hide resolved
test/utils/test-streams.js Outdated Show resolved Hide resolved
@gulpjs gulpjs deleted a comment from ssiltanen May 2, 2023
@phated phated force-pushed the chore-normalize-repository branch from 1872d25 to b88a77e Compare May 31, 2023 23:50
@phated phated changed the title chore: normalize repository and update dependencies feat!: Switch stream implementation to streamx Jun 11, 2023
This was linked to issues Jun 11, 2023
Copy link
Member

@phated phated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests should be green now and I'm happy enough with the diff. Thanks for getting this started @coreyfarrell and thanks for updating @sttk 🎉 This truly was a team effort.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch to streamx Use new buffer methods
3 participants