Expose readFile encoding option through vfs.src

[limdauto]

Here is a PR for src regarding #23.

I will add support for dest if this is up to par :)

[callumacrae]

Why not just var options = { encoding: opt.encoding }? If opt.encoding is undefined, it'll be passed through as undefined, which is fine.

[limdauto]

Thanks. Fixed.

[callumacrae]

lgtm except for the one thing

[yocontra]

Test fail?

[limdauto]

@contra it's failing upstream

[yocontra]

just typeof is sufficient here, no need for both checks. then you can make this a ternary

[limdauto]

That's true

[yocontra]

if (typeof data === 'string') {
  data = new Buffer(data, opt.encoding);
}
file.contents = stripBom(data);

would be cleanest imo

[yocontra]

How does this work with writing files out? Aren't we going to need to specify the encoding there as well

[limdauto]

@contra I understand without passing encoding to writing out, all this is kind of pointless. I just made the PR to see if I'm on the right track. Will add dest shortly.

[sindresorhus]

What use-case is this solving exactly? When would you ever need to be able to specify ascii encoding?

[phated]

Encoding doesn't really make sense because we always read in as buffer, which doesn't have an encoding. Plugins use toString() on that buffer to turn it into a string, so there's not a good way to expose the encoding information without breaking all plugins.

[sindresorhus]

I would think https://github.com/heldinz/gulp-convert-encoding would be a better solution if you're using obscure encodings.

[limdauto]

Hi guys, so sorry I completely forgot about this PR. It was more than a month ago and I have indeed found out that it's better to convert my stuff to sane encoding first rather than requiring it from gulp/vinyl-fs. Thanks for your comments. I'm closing this.