Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to remove as many options as possible #19

Closed
phated opened this issue Mar 21, 2017 · 9 comments
Closed

Attempt to remove as many options as possible #19

phated opened this issue Mar 21, 2017 · 9 comments

Comments

@phated
Copy link
Member

phated commented Mar 21, 2017

A goal of mine is to gut as many options as we possibly can. We should be able to figure out the right way to do things in many cases, so users shouldn't have to use things like mapFile or mapSources, etc.

I'm not sure exactly which options can be removed but we need to have a deep understanding why people are using it and how we can do that automatically before we can remove an option.

@phated
Copy link
Member Author

phated commented Mar 30, 2017

Creating modules as option replacements at https://github.com/gulp-sourcemaps. If anyone wants to help, I'll give you access to the repo.

@phated
Copy link
Member Author

phated commented Mar 30, 2017

cc @robinvenneman @contra @AlexHenkel or anyone else

@CKGrafico
Copy link

Do you have a list with all options?
options.sourceRoot
options.loadMaps // load loadInlineMaps

@phated
Copy link
Member Author

phated commented Apr 1, 2017

@CKGrafico
Copy link

My opinions about that are only based on my experiences with sourcemaps:

  • loadMaps: I don't use this because I try to use always JS code without min (also with 3rd party) and I'm who minifies the code.
  • identityMap: Never need that
  • addComment: Not for me but I understand that some people need it.
  • includeContent: For me is always true.
  • sourceRoot: if the last is true I don't need it.
  • destPath: I prefer inline sourcemaps but maybe someone not.
  • sourceMappingURLPrefix: Only needed is you don't use inline.
  • sourceMappingURL: The same.
  • mapFile: The same.
  • charset: Mmm never for me but not sure if someone has code without utf-8
  • clone: Never used but could be insteresting.

@Videl
Copy link

Videl commented Apr 9, 2017

@phated, do you have a list of what options needs to be implemented?

@phated
Copy link
Member Author

phated commented Apr 10, 2017

@Videl Almost all the options listed in the comment above yours. I started creating repositories for each at https://github.com/gulp-sourcemaps/ and worked on addComment/sourceMappingURLPrefix/sourceMappingURL (in an open PR) and mapSources. charset doesn't need to be replaced and clone might not need to be (needs to be researched).

@phated
Copy link
Member Author

phated commented Apr 10, 2017

identityMap has been removed because I finished https://github.com/gulp-sourcemaps/identity-map today.

@phated
Copy link
Member Author

phated commented Apr 20, 2017

I just chopped out everything. Will have to create plugins as they are needed but creating them as I tried to remove options was just slowing progress.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants