feat!: Support streaming contents #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've been working on this and I don't think it really makes sense to process chunks of the stream because we'll always need to hold the chunks in memory before we can pass the vinyl file upstream. So I'm going to implement with |
|
@sttk please review! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Started working on streaming support for this. The
writemethod was easy because it assumed that.sourceMapexists on the file so I just needed to add the comment to the stream.I'm hoping to give the
addstuff a go in the next few days as long as nothing major comes up.Closes #32
Closes #36
cc @erikkemperman @nmccready @robinvenneman