Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Option, how to react on unicode errors #18

Closed
gulrak opened this issue May 18, 2019 · 1 comment
Closed

Option, how to react on unicode errors #18

gulrak opened this issue May 18, 2019 · 1 comment
Assignees
@gulrak
Labels
available on master Fix is done on master branch, issue closed on next release enhancement New feature or request
Milestone
v1.2.0

Comments

@gulrak
Copy link
Owner

gulrak commented May 18, 2019

There should be an option to select if unicode errors (invalid byte sequence or bad codepoint) should lead to errors or be replaced by the unicode replacement character (U+FFFD), like it is currently done.
@gulrak gulrak self-assigned this May 18, 2019
@gulrak gulrak added the enhancement New feature or request label May 18, 2019
@gulrak gulrak added this to the v1.2.0 milestone May 18, 2019
gulrak added a commit that referenced this issue May 18, 2019
@gulrak
refs #18, some refactoring on unicode handling and a fix for a VS2019…
9d5bc60 
… warning.
gulrak added a commit that referenced this issue May 18, 2019
@gulrak
refs #18, missing small fix
40ef125
gulrak added a commit that referenced this issue May 18, 2019
@gulrak
refs #18, added missing allocator parameter to std::string case of fr…
6d173c5 
…omUtf8
gulrak added a commit that referenced this issue May 18, 2019
@gulrak
refs #18, revert change due to VS2015 compilation issues.
082e606
gulrak added a commit that referenced this issue May 19, 2019
@gulrak
refs #18, fighting VS2015 sfinae issues
aa1cb70
gulrak added a commit that referenced this issue May 19, 2019
@gulrak
refs #17, refs #18, Missing use of alloc in fromUtf8 (fixed on master…
f4a85d2 
…) and initialization order issue.
gulrak added a commit that referenced this issue May 31, 2019
@gulrak
optional Windows wchar_t/wstring support
3fcb3f5 
Squashed commit of the following:

commit f4a85d2
Author: Steffen Schümann <s.schuemann@pobox.com>
Date:   Sun May 19 10:02:22 2019 +0200

    refs #17, refs #18, Missing use of alloc in fromUtf8 (fixed on master) and initialization order issue.

commit aa1cb70
Author: Steffen Schümann <s.schuemann@pobox.com>
Date:   Sun May 19 09:46:02 2019 +0200

    refs #18, fighting VS2015 sfinae issues

commit 15788d8
Author: Steffen Schümann <s.schuemann@pobox.com>
Date:   Sat May 18 10:35:25 2019 +0200

    refs #17, work on wchar_t/wstring support on Windows.
gulrak added a commit that referenced this issue Jun 2, 2019
@gulrak
refs #18, unicode error raise can now be enabled with define GHC_RAIS…
98dad7f 
…E_UNICODE_ERRORS
@gulrak gulrak added the available on master Fix is done on master branch, issue closed on next release label Jun 2, 2019
@gulrak
Copy link
Owner Author

gulrak commented Jun 2, 2019

This is now part of release v1.2.0

Feature can be enabled with the define: GHC_RAISE_UNICODE_ERRORS

@gulrak gulrak closed this as completed Jun 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gulrak gulrak

Labels
available on master Fix is done on master branch, issue closed on next release enhancement New feature or request
Projects
None yet
Milestone
v1.2.0
Development

No branches or pull requests
1 participant
@gulrak