Fix for the multi-size in- slot

gumgum · Feb 6, 2024 · 4d6cd54 · 4d6cd54
1 parent f8858ae
commit 4d6cd54
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 2 deletions.
diff --git a/modules/gumgumBidAdapter.js b/modules/gumgumBidAdapter.js
@@ -553,10 +553,10 @@ function interpretResponse(serverResponse, bidRequest) {
  sizes = [`${maxw}x${maxh}`];
  } else if (product === 5 && includes(sizes, '1x1')) {
  sizes = ['1x1'];
- } else if (product === 2 && includes(sizes, '1x1')) {
+ } else if ((product === 2 && includes(sizes, '1x1')) || product === 3) {
  const requestSizesThatMatchResponse = (bidRequest.sizes && bidRequest.sizes.reduce((result, current) => {
  const [ width, height ] = current;
- if (responseWidth === width || responseHeight === height) result.push(current.join('x'));
+ if (responseWidth === width && responseHeight === height) result.push(current.join('x'));
  return result
  }, [])) || [];
  sizes = requestSizesThatMatchResponse.length ? requestSizesThatMatchResponse : parseSizesInput(bidRequest.sizes)

diff --git a/test/spec/modules/gumgumBidAdapter_spec.js b/test/spec/modules/gumgumBidAdapter_spec.js
@@ -880,6 +880,19 @@ describe('gumgumAdapter', function () {
  expect(result.height = expectedSize[1]);
  })
 
+ it('request size that matches response size for in-slot', function () {
+ const request = { ...bidRequest };
+ const body = { ...serverResponse };
+ const expectedSize = [[ 320, 50 ], [300, 600], [300, 250]];
+ let result;
+ request.pi = 3;
+ body.ad.width = 300;
+ body.ad.height = 600;
+ result = spec.interpretResponse({ body }, request)[0];
+ expect(result.width = expectedSize[1][0]);
+ expect(result.height = expectedSize[1][1]);
+ })
+
  it('defaults to use bidRequest sizes', function () {
  const { ad, jcsi, pag, thms, meta } = serverResponse
  const noAdSizes = { ...ad }