Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VPAID cannot be replayed after completion #58

Open
edrpls opened this issue Dec 19, 2019 · 1 comment
Open

VPAID cannot be replayed after completion #58

edrpls opened this issue Dec 19, 2019 · 1 comment
Labels
bug Something isn't working
Milestone
2.0.0

Comments

@edrpls
Copy link

edrpls commented Dec 19, 2019

The current implementation doesn't allow to replay VPAID after they are finished and cleaned up. I think this could be fixed by calling the VPAIDWrapper.startAd again, or maybe even __runVPAID again.
edrpls pushed a commit that referenced this issue Dec 26, 2019
Handle VPAID replay (#58)
6569aae
@edrpls edrpls mentioned this issue Dec 26, 2019
Merged
edrpls pushed a commit that referenced this issue Dec 26, 2019
Handle VPAID replay (#58) (#68)
cefa7ff
@edrpls edrpls closed this as completed Dec 26, 2019
@edrpls edrpls reopened this Jan 8, 2020
@edrpls
Copy link
Author

edrpls commented Jan 8, 2020

Fixing #60 broke this again. I think the whole node needs to be rebuilt now instead of just running the VPAID again.

@edrpls edrpls mentioned this issue Jan 8, 2020
Merged
@edrpls edrpls added the bug Something isn't working label Jan 11, 2020
@edrpls edrpls added this to the 2.0.0 milestone Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
1 participant
@edrpls