-
-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
direct_api: Joint.connected_to is now a set(), not singleton #138
base: dev
Are you sure you want to change the base?
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## dev #138 +/- ##
=======================================
Coverage 95.72% 95.72%
=======================================
Files 21 21
Lines 6455 6455
=======================================
Hits 6179 6179
Misses 276 276
☔ View full report in Codecov by Sentry. 📢 Have feedback on the report? Share it here. |
d7fff77
to
f10763a
Compare
Although I can see why this would be useful for linear joints like those on extrusions, it doesn't make sense to me generally. A ball and socket joint can't have two balls in the socket. Rigid joints would be confusing as two parts are likely to overlap. Given that any part can have as many joints as desired, this seems like redundant functionality that just makes everything more difficult to understand. Is there a compelling reason by this approach is required? |
A ball and socket can't have two balls, but a ball can connect to two sockets (double-ball joint in claymation armatures) https://www.animationtoolkit.co.uk/12mm-double-ball-joint/ And with respect to Linear Rails, I'm working on a hardware library for my workflow, and it makes more sense to me to have a single linear joint for each side that I can attach multiple to, instead of having to instance with each specific rail with a unique joint set, ie something like:
|
f10763a
to
1639dab
Compare
1639dab
to
3d8f3e7
Compare
3d8f3e7
to
f336813
Compare
I strongly support the proposal to allow multiple objects to be attached to a single joint, as it adds significant value and flexibility across various joint types:
While this approach may introduce some inaccuracies in real things, it offers significant practical benefits for creating assemblies and similar tasks. I'm curious if this modification, from a single element to a set, necessitates changes in related areas such as assembly processing. Understanding the potential downstream impacts would be important for fully assessing this proposal. Thank you for considering this enhancement. |
This permits multiple attachments to a single joint; for example a common 'origin' virtual mounting point; or multiple attachments to a slot in 2020 aluminum extrusion.