Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix inputs reassignment #123

Merged
merged 3 commits into from
Apr 19, 2018
Merged

Fix inputs reassignment #123

merged 3 commits into from
Apr 19, 2018

Conversation

gund
Copy link
Owner

@gund gund commented Apr 19, 2018

Related #111

Alex Malkevich added 3 commits April 19, 2018 11:42
fix(directive): Check if inputs really changed when angular triggers …
cc91db3 
…change detection on them

Because object structure might not change while the reference will

closes #111
fix(directive): Check if inputs really changed when angular triggers …
14c953c 
…change detection on them

Because object structure might not change while the reference will

closes #111
Merge branch 'fix-inputs-reassignment' of git-gund:gund/ng-dynamic-co…
31fc008 
…mponent into fix-inputs-reassignment
@codecov-io
Copy link

codecov-io commented Apr 19, 2018 •
edited
Loading

Codecov Report

Merging #123 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #123   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           4      4           
  Lines         191    193    +2     
  Branches       42     43    +1     
=====================================
+ Hits          191    193    +2
Impacted Files Coverage Δ
src/dynamic/dynamic.directive.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68b6e32...31fc008. Read the comment docs.

@gund gund merged commit c1ee504 into master Apr 19, 2018
@gund gund deleted the fix-inputs-reassignment branch April 19, 2018 13:29
@gund
Copy link
Owner Author

gund commented Apr 19, 2018

🎉 This PR is included in version 2.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@snyk-bot snyk-bot mentioned this pull request Oct 27, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gund @codecov-io