Merge pull request #707 from gundam-organization/main

up
gundam-organization · Nov 29, 2024 · 821154c · 821154c
2 parents 9b5ee71 + 3a46e3b
commit 821154c
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/src/Fitter/Minimizer/src/RootMinimizer.cpp b/src/Fitter/Minimizer/src/RootMinimizer.cpp
@@ -285,7 +285,7 @@ void RootMinimizer::minimize(){
     samplesArrList[iSample].writeRawData( getLikelihoodInterface().evalStatLikelihood( samplePair ) );
 
     int nBins = samplePair.model->getHistogram().getNbBins();
-    for( int iBin = 1 ; iBin <= nBins ; iBin++ ){
+    for( int iBin = 0 ; iBin < nBins ; iBin++ ){
       leavesDict.emplace_back("llhSample_bin" + std::to_string(iBin) + "/D");
       samplesArrList[iSample].writeRawData( getLikelihoodInterface().getJointProbabilityPtr()->eval(samplePair, iBin) );
     }

diff --git a/src/StatisticalInference/JointProbability/include/BarlowBeestonBanff2022.h b/src/StatisticalInference/JointProbability/include/BarlowBeestonBanff2022.h
@@ -104,6 +104,14 @@ namespace JointProbability{
                    << std::endl;
           LogError << "nomMC bin " << bin_
                    << " error is " << nomHistErr[bin_];
+
+          DEBUG_VAR(bin_);
+          DEBUG_VAR(mcuncert);
+          DEBUG_VAR(nomHistErr[bin_]);
+          DEBUG_VAR(nomHistErr.size());
+          DEBUG_VAR(nomHistErr.size());
+          DEBUG_VAR(GenericToolbox::toString(nomHistErr));
+
           LogThrow("The mc uncertainty is not a usable number");
         }
         else{