Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow any database model to be used #1001

Merged
merged 4 commits into from
Sep 29, 2017
Merged

Allow any database model to be used #1001

merged 4 commits into from
Sep 29, 2017

Conversation

gunthercox
Copy link
Owner

For #904

@gunthercox
Get rid of use_django_models prameter
1c8d0fb 
Instead of setting a boolean value, these changes will allow any
model to be used.
@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 73.625% when pulling 1c8d0fb on models into b611cbd on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 73.625% when pulling 1c8d0fb on models into b611cbd on master.

vkosuri
vkosuri approved these changes Sep 29, 2017
View reviewed changes
Copy link
Collaborator

@vkosuri vkosuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gunthercox gunthercox merged commit 2cef1ce into master Sep 29, 2017
@gunthercox gunthercox deleted the models branch September 29, 2017 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vkosuri vkosuri vkosuri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gunthercox @coveralls @vkosuri