Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tighter Django integration #471

Merged
merged 8 commits into from
Dec 17, 2016
Merged

Tighter Django integration #471

merged 8 commits into from
Dec 17, 2016

Conversation

gunthercox
Copy link
Owner

@gunthercox gunthercox commented Dec 7, 2016

This makes changes so that if ChatterBot is being used with Django, the Django Statement and Response models can be used in place of ChatterBot's Statement and Response objects. Previously the storage adapter converted incoming statement objects into Django model objects before saving and/or returning them. Now this conversion is no longer required.

This is going to need further testing before it gets merged.

Items that need to be checked off before this can be merged:

  • Make sure ChatterBot statements/responses and the Django models have the same methods
  • Make sure logic adapters all work with in Django
  • Make sure input adapters all work in Django
  • Make sure output adapters all work in Django

Closes #464

@gunthercox gunthercox changed the title Django Tighter Django integration Dec 7, 2016
@gunthercox gunthercox force-pushed the django branch 2 times, most recently from 5954895 to 680c1a4 Compare December 7, 2016 18:39
@gunthercox gunthercox force-pushed the django branch 6 times, most recently from 601c41e to ebd0bc7 Compare December 10, 2016 03:56
@vkosuri
Copy link
Collaborator

vkosuri commented Dec 10, 2016

@gunthercox Any plan to fix this issue #308

@gunthercox
Copy link
Owner Author

@vkosuri I'm planning on taking care of #308 in a pull request after this one gets merged. I'm pretty sure the "reversal" is just an issue with confusing variable names.

@gunthercox gunthercox merged commit d3aa12c into master Dec 17, 2016
@gunthercox gunthercox deleted the django branch December 17, 2016 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants