Disconnect storage from adapter class #552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes a change to seperate the storage adapter from the base Adapter class. This is being done because the methods on the base Adapter class are not needed on the storage adapter. The main change is that is no longer possible for the storage adapter to access the ChatBot instance. This should not cause any probems because there are no "known" use cases where this is needed. This also allows a special case to be removed in the class validation utility so that a check to the "Adapter" class is never made. This allows the class validation utility to be more generic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes a change to separate the storage adapter from the base Adapter class. This is being done because the methods on the base Adapter class are not needed on the storage adapter.
The main change is that is no longer possible for the storage adapter to access the ChatBot instance. This should not cause any problems because there are no "known" use cases where this is needed.
This also allows a special case to be removed in the class validation utility so that a check to the "Adapter" class is never made. This allows the class validation utility to be more generic.