-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Memory and file tests #745
Conversation
Can someone help ? Warning, treated as error: |
Here two issues are there one is pep8 issue Expected single line but it has multiple lines
Another issue dedent issue http://www.sphinx-doc.org/en/stable/markup/code.html#dedent You should specify line number also here
The it should be like this
|
@vkosuri thanks, but I don't know why now build is failing by sphinx documentation in classes that I not touched. :( |
Not sure, A similar issue found here also sphinx-doc/sphinx#3755 |
It's sphinx bug fixed in this revision sphinx-doc/sphinx@dabd356 |
Great news! Maybe need to wait Sphinx v1.6.2 be released. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry about the delay in reviewing this. I've been away for the past week.
I will look into the sphinx issues. Feel free to ignore any failures related to them in this pull request.
def setUp(self): | ||
""" | ||
Make the adapter writable before every test. | ||
Make the adapter read only before every test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't believe this change to the comment is correct. It would be making it read only if it was setting read_only = True
, however the line below is self.adapter.read_only = False
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed.
Hi @gunthercox , sorry, I got stuck. |
@davizucon I might add some changes to this pull request later today. Is it alright if I work on it? |
@gunthercox Absolutely, feel free. |
If someone puts spaces in their database name it should fail. This is their fault and they deserve to get an error.
This will address this #723