Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

进入主界面后弹出IP和端口输入的popupwindow的逻辑更改一下，防止crash #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

进入主界面后弹出IP和端口输入的popupwindow的逻辑更改一下，防止crash #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 28 additions & 16 deletions AndroidWebView/DebugWebView/src/com/tencent/debugwebview/MainActivity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,12 @@ public class MainActivity extends ActionBarActivity implements OnClickListener {
private EditText urlEditTextIndialog;
// button to clear URL
private ImageView clearUrlBtn;

/**
* views for the pop up window to input IP and port
*/
View ipPortView;
PopupWindow ipPortPopupWindow;

/**
* variables for main operation
Expand Down Expand Up @@ -130,16 +136,6 @@ protected void onCreate(Bundle savedInstanceState) {

initVariables();
initViews();

/**
* IP and port change frequently, so show the pop up window to set IP and port at the beginning,
* use post delay or a exception will occur
*/
mHandler.postDelayed(new Runnable() {
public void run() {
showIpPortPopupWindow();
}
}, 200);
}

@Override
Expand All @@ -157,6 +153,19 @@ public boolean onCreateOptionsMenu(Menu menu) {
// Inflate the menu; this adds items to the action bar if it is present.
getMenuInflater().inflate(R.menu.main, menu);
serverMenuItem = menu.findItem(R.id.action_server);

/**
* IP and port change frequently, so show the pop up window to set IP and port at the beginning,
* use post delay or a exception will occur
* It looks weird to add the operation here, the reason is the pup up window is just under the menu icon,
* so, the menu icon must have initialized before the window to show
*/
ipPortView.post(new Runnable() {
@Override
public void run() {
ipPortPopupWindow.showAsDropDown(findViewById(R.id.action_server));
}
});
return true;
}

Expand All @@ -166,7 +175,7 @@ public boolean onOptionsItemSelected(MenuItem item) {
switch (item.getItemId()) {
case R.id.action_server:
// show the dialog to set ip and port
showIpPortPopupWindow();
ipPortPopupWindow.showAsDropDown(findViewById(R.id.action_server));
return true;
case android.R.id.home:
onBackKeyClick();
Expand Down Expand Up @@ -465,6 +474,9 @@ private void initViews() {
mWebView.addJavascriptInterface(new InjectObject(), "Debug");

userAgentString = mWebSettings.getUserAgentString();

// initialize the popupWindow where user can set the IP and port to connect to the server
initIpPortPopupWindow();
}

/**
Expand Down Expand Up @@ -524,19 +536,19 @@ public boolean onEditorAction(TextView v, int actionId, KeyEvent event) {
}

/**
* show a popupWindow where user can set the IP and port to connect to the server
* initialize the popupWindow where user can set the IP and port to connect to the server
*/
private void showIpPortPopupWindow() {
private void initIpPortPopupWindow() {
/**
* initialize the pop up window
*/
View ipPortView = getLayoutInflater().inflate(R.layout.popup_ip_port_input, null);
final PopupWindow ipPortPopupWindow = new PopupWindow(ipPortView, LayoutParams.WRAP_CONTENT,
ipPortView = getLayoutInflater().inflate(R.layout.popup_ip_port_input, null);

ipPortPopupWindow = new PopupWindow(ipPortView, LayoutParams.WRAP_CONTENT,
LayoutParams.WRAP_CONTENT, true);
ipPortPopupWindow.setTouchable(true);
ipPortPopupWindow.setOutsideTouchable(true);
ipPortPopupWindow.setBackgroundDrawable(new BitmapDrawable());
ipPortPopupWindow.showAsDropDown(findViewById(R.id.action_server));

/**
* initialize views in pop up window
Expand Down