hakari: fix canonicalized paths on windows #70
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Encountered error while running on windows
cargo hakari init my-workspace-hack
:G:\proj\myrust\my-workspace-hack, canonical path is not within base path G:\proj\myrust
which isn't helpful, adding custom print for canonical versions was helpful:
canonical_path=\\?\G:\proj\myrust\my-workspace-hack, base=G:\proj\myrust
Solution is canonicalize
base
path too. Doing so on every call ofcanonical_rel_path
isn't optimal, probably it's betterbase
be canonicalized somewhere before.