Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hakari: fix canonicalized paths on windows #70

Closed
wants to merge 1 commit into from

Conversation

klensy
Copy link

@klensy klensy commented Mar 14, 2023

Encountered error while running on windows cargo hakari init my-workspace-hack:
G:\proj\myrust\my-workspace-hack, canonical path is not within base path G:\proj\myrust

which isn't helpful, adding custom print for canonical versions was helpful:
canonical_path=\\?\G:\proj\myrust\my-workspace-hack, base=G:\proj\myrust

Solution is canonicalize base path too. Doing so on every call of canonical_rel_path isn't optimal, probably it's better base be canonicalized somewhere before.

@klensy
Copy link
Author

klensy commented Apr 15, 2023

Kindly ping.

@sunshowers
Copy link
Member

Sorry about missing this earlier, and thanks for the ping. We definitely should canonicalize the base path at a higher level. I'll try implementing this.

@sunshowers
Copy link
Member

Done, thanks again for the bug report!

@sunshowers
Copy link
Member

@klensy this is now out as cargo-hakari 0.9.24.

@klensy
Copy link
Author

klensy commented Apr 16, 2023

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants