Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up GuiComponents #31

Open
3 tasks
gurkenlabs opened this issue Oct 1, 2017 · 0 comments
Open
3 tasks

Clean up GuiComponents #31

gurkenlabs opened this issue Oct 1, 2017 · 0 comments
Labels
enhancement feature MAJOR This label is intended to distinguish major features from all the others.

Comments

@gurkenlabs
Copy link
Collaborator

gurkenlabs commented Oct 1, 2017 •
edited by steffen-wilke
Loading

Currently the implementation of our GuiComponents is not as clean as we want it to be.

  • Constructors with large amounts of parameters
  • Inconsistent behavior
  • Not 100% completed implementations

(There are a lot of codesmells related to these components)

We should streamline all our GUI components and clearly define what they can do and what they can't.
The most important topic is the ease of use of the component interfaces.

  • Introduce a Z-Order (distinguish mouse events -> only top most component)
  • Add documentation about GuiComponents.
  • Test remaining implementations
@gurkenlabs gurkenlabs added this to the v0.4.8-alpha milestone Oct 1, 2017
@gurkenlabs gurkenlabs modified the milestones: v0.4.8-alpha, v0.4.9-alpha Dec 10, 2017
@gurkenlabs gurkenlabs modified the milestones: v0.4.9-alpha, v0.5.0-beta Jan 26, 2018
gurkenlabs pushed a commit that referenced this issue Apr 26, 2018
Setting the location on a GuiComponent now also updates children
5b67722 
Rename setPosition to setLocation for consitency reasons.
The setPosition methods now reuse the setters for x and y internally.

Issue #31
@steffen-wilke steffen-wilke added the MAJOR This label is intended to distinguish major features from all the others. label Jul 24, 2018
This was referenced Jan 13, 2019
Open
Closed
@steffen-wilke steffen-wilke removed this from the v0.5.0-beta milestone Nov 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement feature MAJOR This label is intended to distinguish major features from all the others.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@steffen-wilke