Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Raise/Lower/Stop support for covers #52

Merged
merged 3 commits into from
May 2, 2020

Conversation

bdraco
Copy link
Contributor

@bdraco bdraco commented Apr 26, 2020

I'm working on a Home Assistant PR to add SUPPORT_STOP to covers

@swails
Copy link
Contributor

swails commented Apr 27, 2020

Did the unit tests get run for this PR?

@bdraco
Copy link
Contributor Author

bdraco commented Apr 27, 2020

@swails

 tests/test_leap.py ✓✓✓✓✓                                                                                                                                          21% ██▏       
 tests/test_smartbridge.py ✓✓✓✓✓✓✓✓✓✓✓✓✓✓✓✓✓✓✓                                                                                                                    100% ██████████

Yes

@swails
Copy link
Contributor

swails commented Apr 27, 2020

I meant by Travis :)

@bdraco
Copy link
Contributor Author

bdraco commented Apr 27, 2020

I meant by Travis :)

https://travis-ci.org/github/gurumitts/pylutron-caseta
pylutron_caseta/smartbridge.py:25:0: R0904: Too many public methods (23/20) (too-many-public-methods)

@bdraco
Copy link
Contributor Author

bdraco commented Apr 27, 2020

@swails
Copy link
Contributor

swails commented Apr 27, 2020

It looks like for some reason Travis isn't able to post back to Github with the build status -- @mdonoughe since you seem to have admin-y like rights here, can you check the settings to see if there is a problem with Travis posting bulid status back here?

@mdonoughe
Copy link
Collaborator

I don't know what's going on with Travis and I don't think I have access to any Travis-related settings for this repo. Hopefully it was just a temporary integration issue.

@mdonoughe mdonoughe merged commit c6c560d into gurumitts:dev May 2, 2020
@mdonoughe mdonoughe mentioned this pull request Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants