-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support to UpdateItemExpectation for additional properties #38
Open
caldwecr
wants to merge
17
commits into
gusaul:master
Choose a base branch
from
caldwecr:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds ConditionExpression support - Adds ExpressionAttributeNames support - Adds ExpressionAttributeValues support - Adds UpdateExpression support
Add support to UpdateItemExpectation for additional properties
This reverts commit 393a4eb.
…upport_newer_assertions Update UpdateItemWithContext to have same expectation checks
…upport_newer_assertions Fix module path to caldwecr/go-dynamock
…_matcher Add update expression equivalence matcher
…in error - When one of the various expectation checks fails for an update clause, the message that is shown to the user should be unique and differentiated from others. Doing this makes it easier to debug which part of a mock failed its expectation.
…tchers Update Update expectations checker to give specific expectation type …
Why hasn't this been merged? Is there anything I can do to help get this in? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of UpdateItem / UpdateItemWithContext includes attributes that are currently not able to be asserting on by Dynamock. This PR adds the following:
Adds ConditionExpression support
Adds ExpressionAttributeNames support
Adds ExpressionAttributeValues support
Adds UpdateExpression support