Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tuples! #94

Merged
merged 39 commits into from
Feb 9, 2021
Merged

Tuples! #94

merged 39 commits into from
Feb 9, 2021

Conversation

hypercubestart
Copy link
Collaborator

@hypercubestart hypercubestart commented Dec 4, 2020 •
edited
Loading

Included in this PR:

  • new glenside language constructs
    • ConstructTuple
    • TupleGetItem
  • additional Relay Opaque Operators
    • RelayLeakyReLU
    • RelayAvgPool2D
    • RelayUpSampling
    • RelaySigmoid
    • RelayMaximum
    • RelayMinimum
  • edit fn create_worklist in from_relay/mod.rs to efficiently parse larger programs
  • edit run_relay.py to allow tuple output

@hypercubestart hypercubestart mentioned this pull request Dec 8, 2020
Closed
@gussmith23 gussmith23 self-requested a review January 11, 2021 18:10
gussmith23
gussmith23 requested changes Jan 11, 2021
View reviewed changes
Copy link
Owner

@gussmith23 gussmith23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First pass!

src/codegen.rs Show resolved Hide resolved
src/codegen.rs Outdated Show resolved Hide resolved
src/codegen.rs Show resolved Hide resolved
src/codegen.rs Outdated Show resolved Hide resolved
Cargo.toml Show resolved Hide resolved
src/language/from_relay/mod.rs Show resolved Hide resolved
src/language/from_relay/mod.rs Outdated Show resolved Hide resolved
src/language/language.rs Outdated Show resolved Hide resolved
src/language/language.rs Outdated Show resolved Hide resolved
src/language/language.rs Show resolved Hide resolved
gussmith23
gussmith23 reviewed Jan 20, 2021
View reviewed changes
Copy link
Owner

@gussmith23 gussmith23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More comments. Also waiting on tests in from_relay, when you get the chance!

src/language/from_relay/mod.rs Outdated Show resolved Hide resolved
src/language/language.rs Outdated Show resolved Hide resolved
src/language/from_relay/mod.rs Outdated Show resolved Hide resolved
src/language/language.rs Outdated Show resolved Hide resolved
@hypercubestart hypercubestart mentioned this pull request Jan 20, 2021
Open
@gussmith23 gussmith23 changed the title [WIP] tuples! Tuples! Jan 25, 2021
gussmith23
gussmith23 reviewed Jan 25, 2021
View reviewed changes
Copy link
Owner

@gussmith23 gussmith23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more comments! Nearly there. These comments are mostly about tests.

Cargo.toml Show resolved Hide resolved
src/codegen.rs Outdated Show resolved Hide resolved
src/codegen.rs Show resolved Hide resolved
src/language/from_relay/mod.rs Outdated Show resolved Hide resolved
src/language/from_relay/mod.rs Outdated Show resolved Hide resolved
src/language/from_relay/run_relay.py Show resolved Hide resolved
src/language/from_relay/run_relay.py Show resolved Hide resolved
src/language/language.rs Outdated Show resolved Hide resolved
src/language/language.rs Outdated Show resolved Hide resolved
src/language/language.rs Outdated Show resolved Hide resolved
gussmith23
gussmith23 approved these changes Feb 9, 2021
View reviewed changes
Copy link
Owner

@gussmith23 gussmith23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll merge this once I make sure the tests pass! Thanks so much for all of your hard work!!

@gussmith23
Copy link
Owner

@hypercubestart hmm...any idea where this new error would be coming from? https://github.com/gussmith23/glenside/pull/94/checks?check_run_id=1866343438

It seems pretty dumb...it seems like somehow this line is running, even though the path already exists. It's really odd to me that only a single test is failing with this error, too.

@hypercubestart
Copy link
Collaborator Author

hypercubestart commented Feb 9, 2021 •
edited
Loading

@gussmith23 ah I think i ran into that before, and rerunning the tests worked

@gussmith23
Copy link
Owner

🤞 hope so! i already reran them once, didn't work D:

@gussmith23 gussmith23 merged commit fae7d84 into main Feb 9, 2021
@gussmith23 gussmith23 deleted the tuple branch February 9, 2021 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gussmith23 gussmith23 gussmith23 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hypercubestart @gussmith23