fix regex case of (#171)

guybedford · Apr 27, 2024 · 3c40904 · 3c40904
1 parent 864ca9d
commit 3c40904
Show file tree

Hide file tree

Showing 5 changed files with 14 additions and 4 deletions.
diff --git a/lib/lexer.asm.js b/lib/lexer.asm.js
diff --git a/lib/lexer.emcc.asm.js b/lib/lexer.emcc.asm.js
diff --git a/lib/lexer.wasm b/lib/lexer.wasm
diff --git a/src/lexer.c b/src/lexer.c
@@ -871,7 +871,7 @@ bool readPrecedingKeywordn (char16_t* pos, const char16_t* compare, size_t n) {
 }
 
 // Detects one of case, debugger, delete, do, else, in, instanceof, new,
-//   return, throw, typeof, void, yield ,await
+//   return, throw, typeof, void, yield ,await, of
 bool isExpressionKeyword (char16_t* pos) {
   switch (*pos) {
     case 'd':
@@ -908,7 +908,12 @@ bool isExpressionKeyword (char16_t* pos) {
           return false;
       }
     case 'f':
-      if (*(pos - 1) != 'o' || *(pos - 2) != 'e')
+      if (*(pos - 1) != 'o')
+        return false;
+      // of
+      if (pos -2 == source || isBrOrWsOrPunctuatorNotDot(*(pos - 2)))
+        return true;
+      if (*(pos - 2) != 'e')
         return false;
       switch (*(pos - 3)) {
         case 'c':

diff --git a/test/_unit.cjs b/test/_unit.cjs
@@ -39,6 +39,11 @@ function assertExportIs(source, actual, expected) {
 suite('Lexer', () => {
   beforeEach(async () => await init);
 
+  test(`Regex case`, () => {
+    const source = `for(let t of/[0-9]+/g.exec(e)){}`
+    parse(source);
+  });
+
   test(`Source phase imports`, () => {
     const source = `
       import source