Allow importmap overrides in shim mode with option #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Total additional footprint is 7 bytes.
Used for footprint command, but was being loaded as transitive dependency previously.
Had to make a separate test suite, as I couldn't figure out a way to make this test coexist with the existing shim suite, since it required a different override option from the other tests. Open to ideas!
guybedford
approved these changes
Feb 10, 2022
|
With the latest changes we're only 2 bytes higher at 9162 now! I guess refactoring out the resolve functions must have saved enough bytes to make up for everything else, somehow. |
|
Thanks for the quick turnaround on this one - footprint is great! Will release soon, just hoping to get #255 fix in as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #254, this PR adds a
overrideboolean option to allow overriding of existing import map entries in shim mode, defaulting to false to preserve current behavior. Overall increase in footprint is 7 bytes to 9167 according to thenpm run footprintcommand.A few hoops I had to jump through:
Depending on ./config.js in ./common.js introduced a circular dependency, which caused some weird issues in tests. So I ended up refactoring the noop function into its own module to untangle it. I also tried inlining the noop function everywhere, but it ended up making the bundle larger than using a separate module.
For testing, I ended up adding a separate module for this option because I couldn't figure out a way to make the test coexist in the same module without conflicting with the existing importmap overrides tests, which require this option to be off. Open to alternatives!