Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use jar-dependencies for requiring jars #35

Closed
mkristian opened this issue Feb 21, 2015 · 6 comments · Fixed by #52
Closed

use jar-dependencies for requiring jars #35

mkristian opened this issue Feb 21, 2015 · 6 comments · Fixed by #52

Comments

@mkristian
Copy link
Contributor

just added a same request on nokogiri: sparklemotion/nokogiri#1253
so please see the details there.

jrjackson uses jackson and leafy-rack pulls in https://github.com/lookout/leafy/blob/master/leafy-rack/leafy-rack.gemspec#L18 jackson as well.

so to avoid classloader conflicts due to different versions of the same jar are loaded it would be nice to use jar-dependencies which will avoid such cases.

@guyboertje
Copy link
Owner

@mkristian - thanks, this is what I was looking for :-)

Before I started working for Elastic, I did not personally use JrJackson. This means that I had v little time to really troubleshoot this. Now I can.

@colinsurprenant
Copy link
Collaborator

👍

@guyboertje
Copy link
Owner

@mkristian - now that 0.3.4 is released, I can concentrate on this issue.

@mkristian
Copy link
Contributor Author

@guyboertje I am planning to use https://github.com/lookout/leafy and with the current jrjackson setup I need to drop jrjackson as I do not want to have to jackson libraries inside the jruby classloader.

can I setup a PR for vendoring those jackson jars and declare them in the gemspec ?

@guyboertje
Copy link
Owner

@mkristian - Yes please. I have some changes to add as well before I release a new version. This weekend would be a good time for this.

mkristian added a commit to mkristian/jrjackson that referenced this issue Mar 26, 2016
mkristian added a commit to mkristian/jrjackson that referenced this issue Mar 26, 2016
the POM is the Mavenfile and the jars are vendored inside the lib directory

fixes guyboertje#35 and keeps the install semantic as is
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants