-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use jar-dependencies for requiring jars #35
Comments
@mkristian - thanks, this is what I was looking for :-) Before I started working for Elastic, I did not personally use JrJackson. This means that I had v little time to really troubleshoot this. Now I can. |
👍 |
@mkristian - now that 0.3.4 is released, I can concentrate on this issue. |
@guyboertje I am planning to use https://github.com/lookout/leafy and with the current jrjackson setup I need to drop jrjackson as I do not want to have to jackson libraries inside the jruby classloader. can I setup a PR for vendoring those jackson jars and declare them in the gemspec ? |
@mkristian - Yes please. I have some changes to add as well before I release a new version. This weekend would be a good time for this. |
…es inside gemspec fixes guyboertje#35
the POM is the Mavenfile and the jars are vendored inside the lib directory fixes guyboertje#35 and keeps the install semantic as is
just added a same request on nokogiri: sparklemotion/nokogiri#1253
so please see the details there.
jrjackson uses jackson and leafy-rack pulls in https://github.com/lookout/leafy/blob/master/leafy-rack/leafy-rack.gemspec#L18 jackson as well.
so to avoid classloader conflicts due to different versions of the same jar are loaded it would be nice to use jar-dependencies which will avoid such cases.
The text was updated successfully, but these errors were encountered: