-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refreshes are a bit buggy #65
Comments
|
guyfedwards
added a commit
that referenced
this issue
Jun 16, 2024
make refresh a tea.Cmd and batch it with other commands to work with bubbletea instead of doing refresh synchronously disable refresh when in a filtered view closes #65
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It seems that 1, refreshes block the app completely until they're done (which can take up to ~5 seconds), and 2, if you refresh when in the filtered view, your list becomes completely empty.
For point 1, I think it should probably be possible to put the logic for refreshing inside a goroutine, and set an internal variable for "refreshing" or something similar, so that the app doesn't compeletely stop for several seconds.
For point 2, I think the Filter Function just needs to trigger again, but I'm not 100% sure on how to force that. We might just run
ResetFilter()
if nothing else, so that the user isn't greeted with a completely blank page just from running refresh.The text was updated successfully, but these errors were encountered: