feat: refresh without tui interval functionality #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this @coolsloth55. The TUI background refresh can be a separate PR which just calls Overall happy to merge if you just remove the timestamp bit for now, thanks |
guyfedwards
reviewed
Dec 15, 2024
internal/commands/list.go
Outdated
| return listUpdate{ | ||
| items: convertItems(items), | ||
| status: "Refreshed.", | ||
| status: fmt.Sprintf("Refreshed at %s.", now), |
There was a problem hiding this comment.
As the only method for refresh currently is the nom refresh command I don't think a timestamp is needed.
This can be something to add with the TUI background update and maybe shown somewhere dedicated in the UI (bottom or top right maybe) with a relative date
E.g. Updated 5m ago
|
thanks for the contribution @coolsloth55 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial for #101
I couldn't wrap my head around on how to hook into TUI correctly to fetch but also dynamically update list like
rkey does but from some event or go routine.configfor convenience.If timestamp is welcomed I'm also open to making it configurable from config for those who prefer something other than
YYYY-MM-DD hh:mm:ss.