Module docker causes build failures during install of docker-compose #139
Comments
davidzwa
changed the title
|
Strange, it does finish on my builds, just takes a while. About 15 mins on my Pi4. Might be that github are emulating arm and therefore it would take longer, id bet around 20-60 mins. Here is an example log from MtigOS that uses the docker module: Also attaching full log for reference. A way to speed it up would be to build the wheel in advance, or use a 64bit build since they Also there is this comment with a fix I don't fully understand: |
|
To re-iterate: with the installation steps I linked above a wheel build is not needed at all. https://dev.to/elalemanyo/how-to-install-docker-and-docker-compose-on-raspberry-pi-1mo This is all it takes, very different from what the CustomPiOS docker module is doing: The |
|
Ok, gotcha. Is the apt upgrade required? Any idea what it is fixing? Apart from that, the module also runs the same up to here The lines here in your solution: Are replaced by this in the docker module (source): I rather not change the base image as much as I can, since we expect Rpi-Foundation to maintain their image. Though we could add a flag for now At least until Rpi upgrade to Bullseye (which would be likely before 2022 when Buster reaches EOL). |
|
Yeah it would be bad if we'd require |
|
I was able to build the raspbian base without problems. Here's the start script with some corrections like Havent tested docker-compose on the image + host, but I trust it will succeed |
|
Looks like what you change is installing python3-pip from the distribution and not for the internet? |
|
Looking at the By looking at the get-pip file it downloads pip3 |
|
Ok, tried to add python3-pip and it still takes a long time, log: Can you provide the log what what managed to build for you? |
There's a lot more in that install than what I am using. The package difference:
I highly suggest removing these build tool related packages like gcc and cargo (rust?) what you dont need as these are the cause for version constraints failing (I assume). |
|
Here's my log when building for raspbian. The build takes around 5 minutes in total. |
|
Looks like it says that PyNaCl has a wheel, but form an unexpected location: So it its pulling it. The url is: It says it needs to include that in This is unlike the long loop for in my builds: This actually might connect to the long standing PR #123. I does seem to appear in Rpi OS |
|
I am going to try adding: And see if that makes the build finish faster, if so the full fix will be: if [ "${BASE_DISTRO}" == "raspbian" ]; then
pip3 install --index-url=https://www.piwheels.org/simple PyNaCl
fiThis way it will only do that in Rasbian |
|
Think I hit something strange or a dumb misstake. On an OctoPi instance I get |
I dont agree that this is the fix. My honest opinion is that you're only making it harder. PyNaCl is not our problem to deal with... I hope you see my point. It's a problem for Please confirm that you've tried the following or not: |
PyNaCl is the problem according to the log you supplied in the issue report. Here is the output as a screenshot from that log so you dont need to scroll all the way down: |
|
No this problem is gone as I shared in this comment 😉 There's no wheel for pynacl in that log. |
|
I am sorry if its a little repetitive. It just also wanted to make a summary of what I understand the problem is.
Indeed, as I said in comment #139 (comment) , it seems like the way that got solved there is because the pynacl got installed via piwheels, which is a raspberry pi-spasific wheel repository (as in not PyPi). So that log difference from what I understood is what need to happen for the build not to break as given in the initial log of the issue. |
|
Going to close this as it might be completely different now and I'm not running docker anymore due to lingering overlay2 folders etc. |
|
I recently fixed docker compose and docker on some systems, it might have fixed this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Built an image without docker and then I added the docker module.
CustomPiOS: devel
Error summary: cargo or rust cause wheel build which never finishes. The fact that a wheel build is necessary tells me something is wrong with the pip packages to start with. I could share the errors TL;DR a docker-compose dependency
Error log: please visit my public repository and this build log line https://github.com/davidzwa/mtb3dpi-image/pull/1/checks?check_run_id=3255944271#step:8:1235
Attempt to fix: I ran the instructions on https://dev.to/elalemanyo/how-to-install-docker-and-docker-compose-on-raspberry-pi-1mo as Ive done many times before (hence this custom pi OS attempt) with success. The instructions install much less deps, which makes me wonder if we can simplify it here as well.
Reproduction:
I hope this information is dense enough. Willing to PR.
The text was updated successfully, but these errors were encountered: