fix: fix handling of resolv.conf file #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes changes if resolv.conf is a symbolic link Mostly affected are armbian based images Signed-off-by: Stephan Wendel <me@stephanwe.de>
KwadFan
added a commit
to KwadFan/MainsailOS-dev
that referenced
this pull request
Aug 6, 2024
This run is to proof function of guysoft/CustomPiOS#226 Signed-off-by: Stephan Wendel <me@stephanwe.de>
|
Ok looks good - did you test it? |
|
Yes, see this run https://github.com/mainsail-crew/MainsailOS/actions/runs/10264564806 Also flashed an Image, see https://github.com/mainsail-crew/MainsailOS/actions/runs/10264564806/job/28398906631#step:3:1669 For reference lines from build log |
|
@KwadFan Is this ready to be merged? |
You wanted it to test, so, did you test? |
|
Ah, yes I did, will do when I have time. |
|
Not getting to it, people are reporting that its needed, merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes changes if resolv.conf is a symbolic link
Mostly affected are armbian based images.
If you want to go through whole logs of build please see:
https://github.com/KwadFan/MainsailOS-dev/actions/runs/10264062537
As earlier said on discord:
What it does:
BASE_USE_ALT_DNSI think this is less invasive as PR #224
Regards Kwad