Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avconv is not available in buster #600

Closed
JirkaChadima opened this issue Aug 16, 2019 · 9 comments
Closed

avconv is not available in buster #600

JirkaChadima opened this issue Aug 16, 2019 · 9 comments

Comments

@JirkaChadima
Copy link

What were you doing?

  1. Run a print with a timelapse set
  2. Print ends, timelapse creation crashes with 255 Unknown Error

What did you expect to happen?

Get a timelapse

What happened instead?

No timelapse. Getting the following error in octoprint.log

2019-08-16 09:54:41,183 - octoprint.timelapse - ERROR - Could not render movie due to unknown error
Traceback (most recent call last):
  File "/home/pi/oprint/local/lib/python2.7/site-packages/octoprint/timelapse.py", line 833, in _render
    p = sarge.run(command_str, stdout=sarge.Capture(), stderr=sarge.Capture())
  File "/home/pi/oprint/local/lib/python2.7/site-packages/octoprint/util/fixes.py", line 24, in decorated_function
    return f(*args, **kwargs)
  File "/home/pi/oprint/local/lib/python2.7/site-packages/sarge/__init__.py", line 1462, in run
    p.run(input=input, async_=async_)
  File "/home/pi/oprint/local/lib/python2.7/site-packages/octoprint/util/fixes.py", line 24, in decorated_function
    return f(*args, **kwargs)
  File "/home/pi/oprint/local/lib/python2.7/site-packages/sarge/__init__.py", line 1071, in run
    self.run_node(node, input=input, async_=False)
  File "/home/pi/oprint/local/lib/python2.7/site-packages/octoprint/util/fixes.py", line 24, in decorated_function
    return f(*args, **kwargs)
  File "/home/pi/oprint/local/lib/python2.7/site-packages/sarge/__init__.py", line 1187, in run_node
    result = getattr(self, method)(node, input, async_)
  File "/home/pi/oprint/local/lib/python2.7/site-packages/octoprint/util/fixes.py", line 24, in decorated_function
    return f(*args, **kwargs)
  File "/home/pi/oprint/local/lib/python2.7/site-packages/sarge/__init__.py", line 1333, in run_command_node
    node.cmd.run(input=input, async_=async_)
  File "/home/pi/oprint/local/lib/python2.7/site-packages/octoprint/util/fixes.py", line 24, in decorated_function
    return f(*args, **kwargs)
  File "/home/pi/oprint/local/lib/python2.7/site-packages/sarge/__init__.py", line 658, in run
    raise ValueError('Command not found: %s' % self.args[0])
ValueError: Command not found: /usr/bin/avconv

Did the same happen when running OctoPrint in safe mode?

Yes

Version of OctoPi

Fully updated/upgraded nightly build for RPi4, 0.17.0

Printer model & used firmware incl. version

Prusa MK3S

Screenshot(s)/video(s) showing the problem:

I have read the FAQ.

@JirkaChadima
Copy link
Author

JirkaChadima commented Aug 16, 2019

It's probably due to libav-tools getting dropped from Buster, I'll check if timelapse gets created with ffmpeg instead of avconv.

edit: Works with ffmpeg, so I guess this is jsut a matter of changing the configuration of the pre-built image.

@guysoft
Copy link
Owner

guysoft commented Aug 18, 2019

Ok, can you write in detail what packages you installed and what configuration you changed for it to work.

Also cc @foosel this means timelapse is broken in nightly

@JirkaChadima
Copy link
Author

Sure. I tried to install ffmpeg package, but it turns out it's already installed in the factory octopi image. So all I did in the end was to change the configuration in OctoPrint's UI from /usr/bin/avconv to /usr/bin/ffmpeg

Octopi is setting the path here and I was not able to find any mention of avconv in octoprint's master branch. I think the fix for buster would be to change the path in octopi's build config.

@guysoft
Copy link
Owner

guysoft commented Oct 23, 2019

This should be fixed in nightly, anyone can confirm?

@JirkaChadima
Copy link
Author

The one from October 13 on this page? I can confirm, but in a few days time, I'm a little busy ATM.

@guysoft
Copy link
Owner

guysoft commented Oct 23, 2019

@JirkaChadima Yes that should include the fix, confirm when you can :)

guysoft added a commit that referenced this issue Oct 24, 2019
Fix avconv is not available in buster #600
@JirkaChadima
Copy link
Author

With

2019-10-13_2019-07-10-octopi-buster-lite-0.17.0.zip 2019-10-13 00:25:06 UTC 661.3MB 95b094797cd526455cbb6f57fefb7940

I'm still seeing avconv preconfigured. So I guess the next nightly after today's PR merge will contain the fix?

@guysoft
Copy link
Owner

guysoft commented Oct 24, 2019

It was merged 2 hours ago. Next nightly.

@guysoft guysoft closed this as completed Oct 24, 2019
@guysoft
Copy link
Owner

guysoft commented Oct 24, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants