enable compression at haproxy layer #643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This spins out of a discussion at [OctoPrint#3529](OctoPrint/OctoPrint#3529), where @flaviut did the math on how enabling http compression is really helpful, even on a little Pi. It'd be nice if we could get it enabled in Tornado, but this is easier and won't be invalidated by work on Tornado if that gets done. haproxy attempts to compress every mime type, and it is a big win. You can go over to the other issue to see the comparisons. It doesn't seem to support setting a compression level, and [it is cautious](https://cbonte.github.io/haproxy-dconv/1.7/configuration.html#compression), so it should be fine. Tested locally.
|
Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This spins out of a discussion at OctoPrint#3529, where @flaviut did the math on how enabling http compression is really helpful, even on a little Pi. It'd be nice if we could get it enabled in Tornado, but this is easier and won't be invalidated by work on Tornado if that gets done.
haproxy attempts to compress every mime type, and it is a big win. You can go over to the other issue to see the comparisons. It doesn't seem to support setting a compression level, and it is cautious, so it should be fine.
Tested locally.