Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write output to stdout instead of stderr. #16

Merged
merged 5 commits into from
May 15, 2022
Merged

Conversation

amrsoll
Copy link
Contributor

@amrsoll amrsoll commented Apr 8, 2022

Wraps the main() function in order to continue to test on io.StringIO elements without having to extract it from stdout while printing it for the cli tool.

This addresses a small issue I had by auto-generating the setup.cfg file using setuptools_py2cfg ./setup.py > setup.cfg

All tests are passing.

This should be considered as breaking change that could require a major version bump.

Wraps the main() function in order to continue to test on StringIO
without having to extract it from stdout while printing it for the cli tool.
@KOLANICH
Copy link
Contributor

KOLANICH commented Apr 8, 2022

Dupe of #15

@amrsoll
Copy link
Contributor Author

amrsoll commented Apr 8, 2022

Duh 😅 thx, I had assumed the PRs were not left rotting.

@amrsoll amrsoll closed this Apr 8, 2022
@amrsoll
Copy link
Contributor Author

amrsoll commented Apr 8, 2022

Not really though, as my PR fixes the tests

@amrsoll amrsoll reopened this Apr 8, 2022
@gvalkov gvalkov merged commit e95e88d into gvalkov:master May 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants