Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose create_app_user as a callable script #102

Closed
crowne opened this issue Apr 5, 2022 · 5 comments · Fixed by #103
Closed

expose create_app_user as a callable script #102

crowne opened this issue Apr 5, 2022 · 5 comments · Fixed by #103
Assignees
Labels
question I have a question that I would like to ask

Comments

@crowne
Copy link
Contributor

crowne commented Apr 5, 2022

I have initialization scripts where I would like to create additional app users.
I'd like to be able to call the existing function create_app_user in container-entrypoint.sh
Could this be exposed as a standalone callable script like /opt/oracle/resetPassword

crowne added a commit to crowne/oci-oracle-xe that referenced this issue Apr 6, 2022
@gvenzl gvenzl self-assigned this Apr 9, 2022
@gvenzl gvenzl added the question I have a question that I would like to ask label Apr 9, 2022
@gvenzl
Copy link
Owner

gvenzl commented Apr 9, 2022

Hey @crowne,

What's wrong with running the initialization scripts through the initialization scripts mechanism?

@crowne
Copy link
Contributor Author

crowne commented Apr 10, 2022

Hi Gerald,

There's nothing wrong with the existing initialization script mechanism I am using this mechanism,
however as part of my initialization I need to create additional app users.

In doing so, I wanted to avoid writing multiple create user scripts and rather call a single script multiple times passing the username and password as parameters.

This is already done in the existing function create_app_user in container-entrypoint.sh
However I can't call that existing function from my initialization scripts,
so my suggestion is to extract it out of container-entrypoint.sh making it into a standalone callable script
which can be called by container-entrypoint.sh as well as by additional initialization scripts if necessary.

@gvenzl
Copy link
Owner

gvenzl commented Apr 17, 2022

Hey @crowne,

Ah I see, that does make sense and I can see how that functionality can come in handy for other situations as well.
I saw your PR, thanks a lot for that.
I would like to modularize it a bit further, i.e. not having the same logic twice, but I'm happy to do that change myself once we merge it.
Could I just please ask you to file the PR against the development branch and not main?

gvenzl pushed a commit that referenced this issue Apr 17, 2022
@gvenzl
Copy link
Owner

gvenzl commented Apr 17, 2022

Actually, strike the last part, I was able to change the target branch myself.
Thanks a lot, @crowne, will now work on the modularization part.

@gvenzl
Copy link
Owner

gvenzl commented Apr 23, 2022

This is now available in all images.

@gvenzl gvenzl closed this as completed Apr 23, 2022
gvenzl added a commit that referenced this issue Dec 2, 2024
* Update tests and retries

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Update all references to REGULAR images

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Clean zip files in lib dir

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Remove not needed deps from fortran runtime

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Remove inventory directory

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Move zip file to ORACLE_BASE for host-only vols

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Use SHRINK SPACE for TEMP files

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Exit SQL*Plus on SQL errors

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Add tag and upload scripts

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Remove XDB

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Remove Oracle Text

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Remove Spatial

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Escape $ signs

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Fix rm ctx typo

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Create new TEMP tablespace for SEED

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Shrink UNDO tablespaces

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Intro Artifactory uploads

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Add fully qualified tags

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Update ReadMe

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Undo retention no longer required

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Further reduce 11g slim image

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* No longer needed due to new UNDO tablespace creation

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Remove OJVM and Java Packages + Multimedia and XDK dependencies

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Update ReadMe

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Introduce tests for ORACLE_PASSWORD and ORACLE_RANDOM_PASSWORD

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* ER #16: provide APP user variables

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Add Ora pwd, random pwd and app user/pwd tests

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Remove workspace manager

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Remove OLAP

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Update package dependencies removal

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Make removal messages consistent

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Fix Java Packages removal

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* ER #22: provide GitHub Actions snippet

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Remove Java Package leftovers

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Do not remove SLAX, used for PL/SQL

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Remove Oracle Text, produce SLIM image

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Update dep removal

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Add 18c slim tests

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Do not remove LDAP folder

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Update test descriptions

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* SQLPlus: fail on error

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Remove OJVMSYS leftover

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* ER #23: Support ORACLE_DATABASE

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Add checkpoint after UNDO switch

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Remove GPX, standalone, can be downloaded

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Update container test run script

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Update ReadMe for OARCLE_DATABASE 18c only

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Update ReadMe with SLIM image

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Add slim images to upload scripts

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Remove Spatial

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Remove Oracle R

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Remove Cluster Ready Services (crs)

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Remove Clsuter Verification Utility

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Remove deinstall directory

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Remove Oracle Database Provider for Distributed Relational Database Architecture (DRDA)

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Remove install directory

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Update ReadMe

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Remove 'ord' and 'ordim' directories

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Remove Universal Installer

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Remove additional components

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* update option flag for build script

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Fix typo in sqlnet.ora

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* disable netca

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Register new PDB with Listener

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* set shared servers to 0

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Fix cleanup for non-localhost bulid containers

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Remove unnecessary bianries and libraries

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Doc: Remove unnecessary bianries and libraries

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Add backup for old images

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* use fully qualified image urls

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* invoke backup of old images by default

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Add users to ReadMe

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* List RPM package removal alphabetically

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* List RPM package removal alphabetically

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Gracefully stop listener (now that listener is started manually)

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Fix typo in RPM package removal

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Introducing 21c-full

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Fixing minor Doc bug

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Add image users

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Add 21c supported tags

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Explain persistent containers

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Update 18c to '18c and onwards'

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Add cleanup to 21c images

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Add jOOQ as image user

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Introducing 21c regular

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Fix static ora* location scripts

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Add 21c images for upload

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Update Readme with 21c tags

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Add artifactory upload

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Adding Container Example Start/Creation Script

* Incorporated feedback and fixes from pull request in example script

* Fix for #43

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Remove Oracle Memory Speed (OMS) PMEM binaries

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Remove MLE

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Added PWgen check

* Clean lastlog

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Add 21c backups

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Fix typo for 21 tests

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Fix for #50, set exec permissions for shell scripts

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Add utPLSQL as users

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Better GitHub Actions documentation as per #45

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Document Upscheme user (#56)

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Update RPM package uninstall for new OL image

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Introducing 21c-slim

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Remove ore.so in 18c

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Move REDO resize to other resize operations to avoid 'checkpoint incomplete' during setup

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Resize REDO logs at end to avoid 'checkpoint incomplete' during setup

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Add Sqitch to users as per #46

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* 21-slim GA ready

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Put Docker.io login as first step

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Remove Examples folder from main ReadMe

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Assign variable values before input check

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Fix example script 'pwgen' check

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Introduce fix for #64 (Increase SGA_TARGET on high CPU count)

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Remove Replay Upgrade feature

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Clean up METASTYLESHEET LOBs

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Rebuild pdbsync indexes

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Clean up fed blocks

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Shrink CDB SYSTEM tablespace datafile

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* List Ruby packages users (#66)

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Shrink 21c CDB TEMP datafile

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Shrink 18c TEMP datafile

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Remove OLAP library

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Do not increase SGA_TARGET for 11g (fixes #71) (#72)

Oracle Database 11g XE is restricted to use no more than 1 GB of memory. The
fix for #64 sets the memory to 1.5 GB, so that the database fails to start with
the error:

ORA-47500: XE edition memory parameter invalid or not specified

* Update note for #72

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* ER #60: introduce container minimum memory check

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* ER #61: introduce container minimum memory check

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Update utPLSQL references as per #77

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Provide TDE setup script example as per #70

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* More solid fix for #64

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Enhance documentation for secrets (#69)

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Document HitHub Action container label usage (#81)

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Fix doc bug for APP_USER

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Add CREATE SYNONYM permission to APP_USER. (#94)

* Externalise script createAppUser (#103)

Closes #102

* Modularize app user creation

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Update image users

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Fix typo

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Fix #104

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Inlcude pam package for OS based auth (#57)

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Generic fix for #64

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Include 21-slim in backups

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Pre-create container init folders (#108)

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Enable Diag and Tuning packs (and EM Express) #112

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Disable audit log

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Update ImageDetails.md

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Fix for #109

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Reorder references

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Update references

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Document Apple M chips (#63)

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Implemented --nowait (#119)

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Fix missing link for colima install

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Introduce faststart images ER #36

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Introduce faststart images (ER #36)

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Provide images on GHCR (ER #131)

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* fix #144

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Include -faststart images in backup

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Document recursive init scripts, make output a bit more readable

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Fix #142, use default memory for BUILDKIT

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* #157: Futher specify faststart image use not being for persistency

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Fix typo #168

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* #171 Allow mounting external volume for oradata subfolders (#172)

Signed-off-by: Loïc LEFEVRE <loic.lefevre@gmail.com>

* Fix #171: do not delete directory structure

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Make init script against XE more prominent in README

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Add 'find' utility for 11.2 build

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Add details for enabling In-Memory Columnar processing on XE #188 (#189)

* 21c multiple layers

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* multiple layers faststart

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Multiple layers 18c

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Update faststart for 11g

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* harmonize Dockerfiles

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* multi-layer 11g

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Use user- / group name for chown

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Document -x buildContainerImage.sh parameter

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* use env vars instead of literal

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Remove unnecessary timezone files

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Remove unecessary binaries

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Update ImageDetails with timezone files

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Cleanup comments

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Remove old timezone info 18c

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Further remove binaries in 18c

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Use 7z for data files uncompress

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Don't shasum faststart image build

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Run ORACLE_DATABASE case insensitive tests

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Use docker.io login

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Update Quarkus Reference

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Migrate Benthos

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Migrate Hibernate Reactive

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Healthcheck PDB status for 18c+

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Update resetPassword param documentation

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Update Spring Data reference

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Update .bash_profile variables

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Backport healthcheck from Free images (#215)

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Use XEPDB1 as default

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Update jOOQ reference and 'sqlplus'

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Fix #202, /oradata permissions

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Provide user warning of old images

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Update Ruby on Rails ActiveRecord user

Signed-off-by: gvenzl <gerald.venzl@gmail.com>

* Provide FREE,FREEPDB1 service names (ER #238)

Signed-off-by: Gerald Venzl <gerald.venzl@gmail.com>

* Update readme

Signed-off-by: Gerald Venzl <gerald.venzl@gmail.com>

* Update labels

Signed-off-by: Gerald Venzl <gerald.venzl@gmail.com>

* Fix for #57

Signed-off-by: Gerald Venzl <gerald.venzl@gmail.com>

* Upgrade 7zip

Signed-off-by: Gerald Venzl <gerald.venzl@gmail.com>

* Update ReadMe and docker startup script

Signed-off-by: Gerald Venzl <gerald.venzl@gmail.com>

---------

Signed-off-by: gvenzl <gerald.venzl@gmail.com>
Signed-off-by: Loïc LEFEVRE <loic.lefevre@gmail.com>
Signed-off-by: Gerald Venzl <gerald.venzl@gmail.com>
Co-authored-by: Daniel Haanpaa [Lab0] <dhaanpaa@djhent.us>
Co-authored-by: cedric-v3 <cedric.staniewski@v3consulting.com>
Co-authored-by: Simon Potter <simon@sjp.co.nz>
Co-authored-by: Neil Crow <crowneil@gmail.com>
Co-authored-by: Loïc LEFEVRE <loic.lefevre@gmail.com>
Co-authored-by: Loïc LEFEVRE <loic.lefevre@oracle.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question I have a question that I would like to ask
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants