Revert "feat: add support for wildcard redirect uris"

This reverts commit 3b9638f.
gw2auth · Jul 12, 2024 · b0e4170 · b0e4170
1 parent 3b9638f
commit b0e4170
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 342 deletions.
diff --git a/util/urlmatch.go b/util/urlmatch.go
diff --git a/util/urlmatch_test.go b/util/urlmatch_test.go
diff --git a/web/dev_application_client.go b/web/dev_application_client.go
@@ -2,8 +2,6 @@ package web
 
 import (
 	"crypto/rand"
-	"crypto/sha256"
-	"encoding/base64"
 	"encoding/binary"
 	"errors"
 	"github.com/gofrs/uuid/v5"
@@ -493,13 +491,6 @@ func preprocessRedirectURIs(applicationId, clientId uuid.UUID, redirectURIs []st
 func validateRedirectURIs(redirectURIs []string) error {
 	var err error
 	for _, redirectURI := range redirectURIs {
-		originalRedirectURI := redirectURI
-		if strings.ContainsRune(redirectURI, '*') {
-			hashBytes := sha256.Sum256([]byte(redirectURI))
-			hash := base64.RawURLEncoding.EncodeToString(hashBytes[:])
-			redirectURI = strings.ReplaceAll(redirectURI, "*", "a"+hash+"z") // surround with "a" and "z" to ensure valid hostnames
-		}
-
 		u, parseErr := url.Parse(redirectURI)
 		if parseErr != nil {
 			err = errors.Join(err, parseErr)
@@ -513,12 +504,6 @@ func validateRedirectURIs(redirectURIs []string) error {
 		} else if u.Hostname() == "" {
 			err = errors.Join(err, errors.New("invalid hostname"))
 		}
-
-		if redirectURI != originalRedirectURI {
-			if !util.URLMatch(originalRedirectURI, u) {
-				err = errors.Join(err, errors.New("invalid pattern"))
-			}
-		}
 	}
 
 	return err