Bugfix: allow two detectors exactly in offline search #4464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxtrevor
reviewed
Aug 23, 2023
maxtrevor
approved these changes
Aug 23, 2023
|
@maxtrevor could you merge once the search test completes? Automerge doesnt take that into accoutn and it will take a while so it will be a bit late for me |
Sure |
GarethCabournDavies
added a commit
to GarethCabournDavies/pycbc
that referenced
this pull request
Oct 11, 2023
* bugfix for skipping exclude_zerolag in two-detector-exactly search * Allow the search to use two-detectors exactly * clarify why a job is removed in the exact-coincidence case
PRAVEEN-mnl
pushed a commit
to PRAVEEN-mnl/pycbc
that referenced
this pull request
Nov 3, 2023
* bugfix for skipping exclude_zerolag in two-detector-exactly search * Allow the search to use two-detectors exactly * clarify why a job is removed in the exact-coincidence case
bhooshan-gadre
pushed a commit
to bhooshan-gadre/pycbc
that referenced
this pull request
Mar 4, 2024
* bugfix for skipping exclude_zerolag in two-detector-exactly search * Allow the search to use two-detectors exactly * clarify why a job is removed in the exact-coincidence case
acorreia61201
pushed a commit
to acorreia61201/pycbc
that referenced
this pull request
Apr 4, 2024
* bugfix for skipping exclude_zerolag in two-detector-exactly search * Allow the search to use two-detectors exactly * clarify why a job is removed in the exact-coincidence case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The offline search was erroring when it was trying to run exclude_zerolag without any other statmap files.
This adds some logic to allow that search configuration