Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up pycbc_multi_inspiral with black #4710

Merged
merged 2 commits into from
Apr 24, 2024

Conversation

pannarale
Copy link
Contributor

@pannarale pannarale commented Apr 23, 2024

This PR kickstarts a clean up process of the executable pycbc_multi_inspiral (coherent search).

  1. I ran black --skip-string-normalization --line-length 79 bin/pycbc_multi_inspiral.
  2. I edited the comment "NOTE: Historically, [...]" to make it clearer (hopefully).
  3. I introduced the dictionary time_delay_idx_zerolag to improve readability.

I will limit this PR to these changes and open a new PR once this one is through, otherwise this PR will just grow too much.

  • The author of this pull request confirms they will adhere to the code of conduct

@pannarale pannarale self-assigned this Apr 23, 2024
@pannarale pannarale added the PyGRB PyGRB development label Apr 23, 2024
@pannarale pannarale mentioned this pull request Apr 23, 2024
22 tasks
Copy link
Contributor

@titodalcanton titodalcanton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Long diff, but this is expected from using black. The other two changes look ok.

@titodalcanton titodalcanton merged commit 44b5890 into gwastro:master Apr 24, 2024
33 checks passed
ArthurTolley pushed a commit to ArthurTolley/pycbc that referenced this pull request May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PyGRB PyGRB development
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants