Use approximant parsing argument for make_bayestar #4712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GarethCabournDavies
added
bug
offline search
v23_release_branch
spxiwh
approved these changes
Apr 26, 2024
ArthurTolley
pushed a commit
to ArthurTolley/pycbc
that referenced
this pull request
May 21, 2024
* Use approximant parsing argument for make_bayestar * SPAtmplt not in bayestar
spxiwh
pushed a commit
to spxiwh/pycbc
that referenced
this pull request
May 28, 2024
* Use approximant parsing argument for make_bayestar * SPAtmplt not in bayestar
spxiwh
added a commit
that referenced
this pull request
May 28, 2024
* Use approximant parsing argument for make_bayestar (#4712) * Use approximant parsing argument for make_bayestar * SPAtmplt not in bayestar * Cherry pick [manually] 4683 * Bugfix: allow nothing to be given in --labels (#4681) * Bugfix: allow nothing to be given in --labels * Update bin/all_sky_search/pycbc_upload_single_event_to_gracedb Co-authored-by: Tito Dal Canton <tito.dalcanton@ijclab.in2p3.fr> --------- Co-authored-by: Tito Dal Canton <tito.dalcanton@ijclab.in2p3.fr> * Bump version number --------- Co-authored-by: Gareth S Cabourn Davies <gareth.cabourndavies@ligo.org> Co-authored-by: Tito Dal Canton <tito.dalcanton@ijclab.in2p3.fr>
GarethCabournDavies
added a commit
to GarethCabournDavies/pycbc
that referenced
this pull request
Jul 24, 2024
* Use approximant parsing argument for make_bayestar * SPAtmplt not in bayestar
spxiwh
removed
the
v23_release_branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When generating bayestar skymaps in the upload prep minifollowup, the approximant used was not the same as in the rest of the workflow, this caused issues.
Here we use the standard approximant interface used by other codes in order to work out the appropriate waveform.
Standard information about the request
This is a: bug fix
This change affects: the offline search
This change changes: result presentation / plotting, scientific output
This change: follows style guidelines (See e.g. PEP8), has been proposed using the contribution guidelines
This change will: require a new release on the v23 release branch so that it can be used for o4 LVK results
Motivation
The correct approximant was not being used for the bayestar subprocess, this means the skymaps would be wrong
Contents
I have used standard library code for obtaining the approximant from the command line interface given conditions, rather than only allowing one input.
Links to any issues or associated PRs
None
Testing performed
Previously failing event now runs, with the right approximant. Boundary also moved to ensure that the SPAtmplt --> TaylorF2 check was implemented