Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove einsteinathome folder #4794

Conversation

GarethCabournDavies
Copy link
Contributor

@GarethCabournDavies GarethCabournDavies commented Jun 24, 2024

Remove unmaintained, unused folder

@GarethCabournDavies GarethCabournDavies linked an issue Jun 24, 2024 that may be closed by this pull request
@ahnitz
Copy link
Member

ahnitz commented Jun 25, 2024

@GarethCabournDavies We can probably remove the einsteinathome folder. It's unmaintained at this point and I think unlikely to come back.

@GarethCabournDavies GarethCabournDavies changed the title Remove duplicated gw150914 check Remove einsteinathome folder Jun 26, 2024
@GarethCabournDavies
Copy link
Contributor Author

Is the build script (pycbc_build_eah.sh, described at https://pycbc.org/pycbc/latest/html/building_bundled_executables.html) still used for building bundled executables for use on the OSG?

@spxiwh
Copy link
Contributor

spxiwh commented Jun 26, 2024

We don't bundle in the old way used here. Singularity images now produce the functionality of being able to run on other clusters without having to explicitly install code there.

Copy link
Member

@ahnitz ahnitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! Thanks for the cleanup

@GarethCabournDavies GarethCabournDavies merged commit bcd4277 into gwastro:master Jun 28, 2024
33 checks passed
@GarethCabournDavies GarethCabournDavies deleted the gw150914_checker_duplicated branch June 28, 2024 08:24
prayush pushed a commit to prayush/pycbc that referenced this pull request Nov 21, 2024
* Remove duplicated gw150914 check

* remove einsteinathome

* Remove outdated documentation

* remove references to bundle executables from the docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicated GW150914 checker code
3 participants