Edit make banksim to allow external injection file #4808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahnitz
approved these changes
Jul 1, 2024
| if inj_file_path == "inj.xml": | ||
| pass | ||
| else: | ||
| os.system("cp {} inj.xml".format(inj_file_path)) |
There was a problem hiding this comment.
You should probably shutil instead of a system command, otherwise this seems fine.
prayush
pushed a commit
to prayush/pycbc
that referenced
this pull request
Nov 21, 2024
* functionality to use external inj.xml file in pycbc_make_banksim * updating docs to add the new functionality of using external inj.xml file * Fixing formatting issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Standard information about the request
This is a: new feature
This change affects:
pycbc_make_banksimfunctionThis change changes: documentation, banksim generator
Motivation
At the moment, only
lalapps_inspinjfunction is allowed for creating injection file through the workflow generatorpycbc_make_banksim. With this update, an externally created injection file can also be called.Contents
The code allows for option to use
inj.xmlprovided by user if the user chooses[external_injection]section instead of[inspinj]in the config file.It also indicates the same in the documentation text.
Testing performed
I have tested it by generating the workflow using
inj.xmlgenerated bypycbc_create_injections. It works fine.