Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to copy #4789 for v23_release_branch #4841

Merged
merged 4 commits into from
Aug 6, 2024

Conversation

GarethCabournDavies
Copy link
Contributor

Tests are failing, e.g. #4824.

This is an attempt to get the test running again.
That can't just be cherry-picked onto the branch due to conflicts

@GarethCabournDavies GarethCabournDavies marked this pull request as draft August 5, 2024 08:56
@GarethCabournDavies GarethCabournDavies added the v23_release_branch PRs applied to the v2.3.X release branch or to be cherry-picked if merging to master label Aug 5, 2024
@GarethCabournDavies
Copy link
Contributor Author

Ive limited the scipy version to allow workaround of the issues described in #4796

The solution there was to update for the replacement of interp2d, but here I went for the fewer-changes approach of just limiting scipy's version

@GarethCabournDavies GarethCabournDavies marked this pull request as ready for review August 6, 2024 10:30
@spxiwh spxiwh merged commit bbaa604 into gwastro:v23_release_branch Aug 6, 2024
31 checks passed
@spxiwh
Copy link
Contributor

spxiwh commented Sep 25, 2024

This was merged directly onto the release branch, so removing label (noting that the label indicates that the patch needs merging onto the branch).

@spxiwh spxiwh removed the v23_release_branch PRs applied to the v2.3.X release branch or to be cherry-picked if merging to master label Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants