-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Cython .cpp
files to .gitignore
#4842
Add Cython .cpp
files to .gitignore
#4842
Conversation
pycbc/events/eventmgr_cython.cpp | ||
pycbc/events/simd_threshold_cython.cpp | ||
pycbc/fft/fftw_pruned_cython.cpp | ||
pycbc/filter/matchedfilter_cpu.cpp | ||
pycbc/filter/simd_correlate_cython.cpp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could this use wildcards, e.g. pycbc/*/*.cpp
and pycbc/*/*/*.cpp
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its not necessary to approve, just a question
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That might lead to issues if we ever want to have a .cpp
file in the repo for whatever reason (admittely unlikely).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/gwastro/pycbc/blob/master/pycbc/events/simd_threshold_ccode.cpp (it's not the only one) should not be ignored.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's fine. The alternative is to use
pycbc/*/*.cpp
!pycbc/events/simd_threshold_ccode.cpp
which will negate the ignore command above.
So it depends on whether we have more cpp files included or exclude as to which is more efficient. However the specified method is probably a bit nicer and faster for git status
Add Cython's
.cpp
files to.gitignore
, so that they do not spam the output ofgit status
. Remove what appears to be a typo from 13 years ago (!!!) and correct the entry forPyCBC.egg-info
.Minor QOL change with no functional consequence.