Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cython .cpp files to .gitignore #4842

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

titodalcanton
Copy link
Contributor

Add Cython's .cpp files to .gitignore, so that they do not spam the output of git status. Remove what appears to be a typo from 13 years ago (!!!) and correct the entry for PyCBC.egg-info.

Minor QOL change with no functional consequence.

  • The author of this pull request confirms they will adhere to the code of conduct

Comment on lines +11 to +15
pycbc/events/eventmgr_cython.cpp
pycbc/events/simd_threshold_cython.cpp
pycbc/fft/fftw_pruned_cython.cpp
pycbc/filter/matchedfilter_cpu.cpp
pycbc/filter/simd_correlate_cython.cpp
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this use wildcards, e.g. pycbc/*/*.cpp and pycbc/*/*/*.cpp?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its not necessary to approve, just a question

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That might lead to issues if we ever want to have a .cpp file in the repo for whatever reason (admittely unlikely).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fine. The alternative is to use

pycbc/*/*.cpp
!pycbc/events/simd_threshold_ccode.cpp

which will negate the ignore command above.

So it depends on whether we have more cpp files included or exclude as to which is more efficient. However the specified method is probably a bit nicer and faster for git status

@titodalcanton titodalcanton merged commit 8512940 into gwastro:master Aug 7, 2024
30 checks passed
@titodalcanton titodalcanton deleted the gitignore-maintenance branch August 7, 2024 16:24
prayush pushed a commit to prayush/pycbc that referenced this pull request Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants