Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove readfp (Python 3.12 removes it), use read_file instead #4852

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

WuShichao
Copy link
Contributor

Standard information about the request

This is a: bug fix,

This change affects: config file, inference

This change changes: nothing

This change will: Nothing

Motivation

Replace deprecated ConfigParser readfp with read_file:
python/cpython#92503
https://issues.apache.org/jira/browse/SVN-4899

Contents

Replace deprecated ConfigParser readfp with read_file in __deepcopy__.

Links to any issues or associated PRs

#4688

Testing performed

Additional notes

  • The author of this pull request confirms they will adhere to the code of conduct

Copy link
Contributor

@titodalcanton titodalcanton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@titodalcanton titodalcanton enabled auto-merge (squash) August 12, 2024 15:36
@titodalcanton titodalcanton merged commit ff8e499 into gwastro:master Aug 12, 2024
30 checks passed
@WuShichao WuShichao deleted the remove_readfp branch August 12, 2024 15:57
prayush pushed a commit to prayush/pycbc that referenced this pull request Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants